Make custom cop inherit RuboCop::Cop::Base#9597
Merged
jekyllbot merged 1 commit intojekyll:masterfrom May 22, 2024
Merged
Conversation
Follow rubocop/rubocop#7868. The legacy `RuboCop::Cop::Cop` API is soft deprecated and this PR makes custom cop inherit `RuboCop::Cop::Base` API instead. > maintain any RuboCop extensions, as the legacy API > will be removed in RuboCop 2.0. https://metaredux.com/posts/2020/10/21/rubocop-1-0.html
mattr-
approved these changes
May 22, 2024
Member
mattr-
left a comment
There was a problem hiding this comment.
Thank you for contributing!
@jekyllbot: merge +dev
jekyllbot
added a commit
that referenced
this pull request
May 22, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2024
Koichi ITO: Make custom cop inherit `RuboCop::Cop::Base` (#9597) Merge pull request 9597
monfresh
pushed a commit
to monfresh/jekyll
that referenced
this pull request
Jun 5, 2024
Merge pull request 9597
monfresh
pushed a commit
to monfresh/jekyll
that referenced
this pull request
Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a 🔨 code refactoring.
Summary
This PR uses
RuboCop::Cop::Basefor custom cops.Context
Follow rubocop/rubocop#7868.
The legacy
RuboCop::Cop::CopAPI is soft deprecated and this PR makes custom cop inheritRuboCop::Cop::BaseAPI instead.https://metaredux.com/posts/2020/10/21/rubocop-1-0.html