Skip to content

Fix --livereload-ignore option#9570

Merged
jekyllbot merged 4 commits intojekyll:masterfrom
mslinn:mslinn-patch-1
Sep 11, 2024
Merged

Fix --livereload-ignore option#9570
jekyllbot merged 4 commits intojekyll:masterfrom
mslinn:mslinn-patch-1

Conversation

@mslinn
Copy link
Copy Markdown
Contributor

@mslinn mslinn commented Mar 28, 2024

This is a 🐛 bug fix.

Summary

Makes livereload_ignore finally work properly.

Context

Fixes #9502

@mslinn
Fixes jekyll#9502
7e0cfec 
Makes `livereload_ignore` finally work properly.
@ashmaroli
Copy link
Copy Markdown
Member

ashmaroli commented Sep 8, 2024

Hello @mslinn,
My local tests show that your changes doesn't actually fix the livereload_ignore at my end. I would normally ask you to add tests but for now, could you add some log outputs or puts calls and confirm that your test ignore_pattern is actually respected.

@ashmaroli ashmaroli added this to the 4.4 milestone Sep 11, 2024
@ashmaroli ashmaroli changed the title Fixes #9502 Fix --livereload-ignore option Sep 11, 2024
@ashmaroli
Copy link
Copy Markdown
Member

ashmaroli commented Sep 11, 2024

Thanks @mslinn
@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit 0fde781 into jekyll:master Sep 11, 2024
jekyllbot added a commit that referenced this pull request Sep 11, 2024
@jekyllbot
Update history to reflect merge of #9570 [ci skip]
bc443c2
github-actions bot pushed a commit that referenced this pull request Sep 11, 2024
@jekyllbot
Deploy docs from 0fde781
32ef288 
Mike Slinn: Fix `--livereload-ignore` option (#9570)

Merge pull request 9570
@jekyll jekyll locked and limited conversation to collaborators Sep 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ashmaroli ashmaroli ashmaroli approved these changes

Assignees

No one assigned

Labels

bug fix frozen-due-to-age

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

[Bug]: livereload-ignore option doesn't work

3 participants

@mslinn @ashmaroli @jekyllbot