Jekyll docs template typo - All pages show "Deployment"#9548
Merged
jekyllbot merged 2 commits intojekyll:masterfrom Feb 13, 2024
Merged
Jekyll docs template typo - All pages show "Deployment"#9548jekyllbot merged 2 commits intojekyll:masterfrom
jekyllbot merged 2 commits intojekyll:masterfrom
Conversation
Member
|
Thanks for fixing this! It's a great PR. ❤️ @jekyllbot: merge +docs |
mattr-
approved these changes
Feb 13, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Feb 13, 2024
velle: Jekyll docs template typo - All pages show "Deployment" (#9548) Merge pull request 9548
monfresh
pushed a commit
to monfresh/jekyll
that referenced
this pull request
Jun 5, 2024
Merge pull request 9548
monfresh
pushed a commit
to monfresh/jekyll
that referenced
this pull request
Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a 🐛 bug fix.
Summary
page->current_pagecurrent_pagetoitem_pagein docs_contents_mobile.html and docs_contents.htmlI did the two fixes above as separate commits. This will be my very first PR, so I am not sure if you can see that I did two commits and see the description for each of them.
I would very much appreciate if you let me do if I did things the right way with this PR :)
Context