Fix gem quote consistency on docs#9517
Merged
jekyllbot merged 1 commit intojekyll:masterfrom Jan 12, 2024
Merged
Conversation
Member
|
👋 Jekyll's style guide says to prefer double quotes over single quotes. Rather than switch things to single quotes, would you be willing to switch things to double quotes instead? |
Author
|
Good to know! And yeah sure I'm willing to amend the commit to double quotes instead of single quotes instead. Could you link me the style guide first? |
Member
|
.rubocop.yml in this repository are the rules. We don't have anything "officially" documented 😅 |
Author
|
That's good enough documentation for me. I changed the single quotes to double quotes on all .md pages. |
mattr-
approved these changes
Jan 12, 2024
Member
mattr-
left a comment
There was a problem hiding this comment.
Thanks!
@jekyllbot: merge +docs
jekyllbot
added a commit
that referenced
this pull request
Jan 12, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jan 12, 2024
Akira Taguchi: Fix gem quote consistency on docs (#9517) Merge pull request 9517
Contributor
monfresh
pushed a commit
to monfresh/jekyll
that referenced
this pull request
Jun 5, 2024
Merge pull request 9517
monfresh
pushed a commit
to monfresh/jekyll
that referenced
this pull request
Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changed all documentation double quotes to single quotes. In some places there already was a use of single quotes and this is what Bundler suggests to use.
Context
Documentation.