Conversation
Member
Author
|
@mattr- This should be ready for ya. |
mattr-
approved these changes
Dec 29, 2023
Member
|
@jekyllbot: merge +dev |
jekyllbot
added a commit
that referenced
this pull request
Dec 29, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Dec 29, 2023
Parker Moore: Fix Performance/StringIdentifierArgument violation in site.rb and allow activesupport 6 for windows tests (#9512) Merge pull request 9512
monfresh
pushed a commit
to monfresh/jekyll
that referenced
this pull request
Jun 5, 2024
…ow activesupport 6 for windows tests (jekyll#9512) Merge pull request 9512
monfresh
pushed a commit
to monfresh/jekyll
that referenced
this pull request
Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a 🔨 code refactoring.
Summary
A Performance/StringIdentifierArgument violation snuck in.
Also, AppVeyor tests were failing due to activesupport and tzinfo version conflicts.
Context
I noticed in other PRs that this was failing on code that was unchanged.
This should allow the CI check "Style Check" to pass.