Test suite uses shoulda-context only.#9441
Merged
jekyllbot merged 1 commit intojekyll:masterfrom Sep 15, 2023
Merged
Conversation
mattr-
approved these changes
Sep 15, 2023
Member
mattr-
left a comment
There was a problem hiding this comment.
Thanks!
@jekyllbot: merge +dev
jekyllbot
added a commit
that referenced
this pull request
Sep 15, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Sep 15, 2023
Vít Ondruch: Test suite uses shoulda-context only. (#9441) Merge pull request 9441
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a 🙋 feature or enhancement.
Summary
Replace shoulda by shoulda-context
Context
AFAICT, only shoulda-context is used for Jekyll test suite. Therefore replacing
shouldabyshoulda-contextshould:Apart from this, I remember times when
shouldagem was not really maintained. The stable version still references toshoulda-matchers 4, whileshoulda-matchers 5were released more then 2 years ago.