Bump versions of ruby & nodejs in devcontainer#9360
Merged
jekyllbot merged 1 commit intojekyll:masterfrom May 8, 2023
Merged
Conversation
This change fixes jekyll#9358. I've updated the NodeJS version to the 18.x LTS release branch. This fixes the NodeJS deprecation error that initially broke the build. In addition, I have bumped the ruby Docker image version to 3.0 which fixes a rubygems mismatch that further broke the devcontainer build. I've confirmed that script/cibuild passes. The results are in a gist here: https://gist.github.com/jmahoney/76e7d3ae3833aacb9138d17671208bc5
ashmaroli
approved these changes
May 8, 2023
Member
|
Thanks @jmahoney |
jekyllbot
added a commit
that referenced
this pull request
May 8, 2023
github-actions bot
pushed a commit
that referenced
this pull request
May 8, 2023
Joe Mahoney: Bump versions of ruby & nodejs in devcontainer (#9360) Merge pull request 9360
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a 🐛 bug fix
Summary
I've updated the NodeJS version in the devcontainer to the 18.x LTS release branch. This fixes the NodeJS deprecation error that initially broke the devcontainer build.
In addition, I have bumped the ruby Docker image version to 3.0 which fixes a rubygems mismatch that further broke the devcontainer build.
I've confirmed that script/cibuild passes. The results are in a gist here: https://gist.github.com/jmahoney/76e7d3ae3833aacb9138d17671208bc5
Context
Fixes #9358