Skip to content

Split test/test_tags.rb into multiple files#9230

Merged
jekyllbot merged 2 commits intojekyll:masterfrom
ashmaroli:split-test-tags
Dec 26, 2022
Merged

Split test/test_tags.rb into multiple files#9230
jekyllbot merged 2 commits intojekyll:masterfrom
ashmaroli:split-test-tags

Conversation

@ashmaroli
Copy link
Copy Markdown
Member

Summary

test/test_tags.rb is currently a monolith file testing all Liquid tags implemented in Jekyll core.
Split this file into individual files for each tag for better readability and maintainability.

  • with FN pattern test/test_tag_TAGNAME.rb.
  • Inherits from new TagUnitTest subclassed from JekyllUnitTest.

Context

#9188 (comment) by @mattr-.

@ashmaroli ashmaroli requested a review from mattr- December 26, 2022 13:25
Copy link
Copy Markdown
Member

@mattr- mattr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. :shipit:

@ashmaroli
Copy link
Copy Markdown
Member Author

Thanks Matt, I'll merge after the CI finishes running.

@ashmaroli
Copy link
Copy Markdown
Member Author

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit ee3576e into jekyll:master Dec 26, 2022
jekyllbot added a commit that referenced this pull request Dec 26, 2022
@ashmaroli ashmaroli deleted the split-test-tags branch December 26, 2022 14:16
github-actions bot pushed a commit that referenced this pull request Dec 26, 2022
Ashwin Maroli: Split `test/test_tags.rb` into multiple files (#9230)

Merge pull request 9230
@jekyll jekyll locked and limited conversation to collaborators Dec 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants