Skip to content

Use check-spelling/check-spelling@v0.0.21#9199

Merged
jekyllbot merged 8 commits intojekyll:masterfrom
jsoref:spell-check
Feb 1, 2023
Merged

Use check-spelling/check-spelling@v0.0.21#9199
jekyllbot merged 8 commits intojekyll:masterfrom
jsoref:spell-check

Conversation

@jsoref
Copy link
Copy Markdown
Contributor

@jsoref jsoref commented Nov 29, 2022

This is a 🐛 bug fix.

Summary

  • It refreshes the check-spelling workflow based on check-spelling/spell-check-this@main.
  • It upgrades check-spelling to v0.0.21
  • Updating metadata has been simplified (and should work well on Windows)
  • candidate.patterns will suggest entries for patterns.txt, e.g.: 
    # Automatically suggested patterns
# hit-count: 23 file-count: 15
# GitHub SHAs (markdown)
(?:\[`?[0-9a-f]+`?\]\(https:/|)/(?:www\.|)github\.com(?:/[^/\s"]+){2,}(?:/[^/\s")]+)(?:[0-9a-f]+(?:[-0-9a-zA-Z/#.]*|)\b|)

Context

  • I released v0.0.21 this week.
  • v0.0.20 will now warn about its use, and shortly it will actively refuse to run. As configured, this repository can run w/o risk, but I'd like to block its use and am thus am trying to migrate everyone to the newer release.

@jsoref
spelling: add
374d247 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: github
eefdcb9 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: gitlab
e31dbb4 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: into
c49ab3d 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: nonexistent
732dbd5 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: preexisting
f543b52 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: workaround
ce35504 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
jsoref
jsoref commented Nov 29, 2022
View reviewed changes
@ashmaroli
Copy link
Copy Markdown
Member

ashmaroli commented Nov 30, 2022

Thank you for upgrading our workflow to the newer version.
Regarding the proposed changes, it is weird that one has to explicitly mention a desired spelling and its variation as plural form e.g. workaround and workarounds, etc.

@jsoref
Copy link
Copy Markdown
Contributor Author

jsoref commented Nov 30, 2022

I initially had logic that was a lot more tolerant of ss. And then I ran into the 🥔 🐛 - potato bug -- namely the plural of potato is not potatos. It was so embarrassing, since I learned the proper spelling in elementary school. It was also a big deal as a Vice President suggested potatoe to a student.

The only "fix" for this is supplemental dictionaries that are more complete.

As it happens, some of the dictionaries that check-spelling considers (the main cpp one and the win32 one) have way more words, but they unfortunately have gobs of typos, which means they're really not great to use -- I need to spend a couple of days or weeks pruning out their typos before I could personally suggest using them (I tried for cpp a couple of times and gave up)...

@ashmaroli
Copy link
Copy Markdown
Member

ashmaroli commented Feb 1, 2023

Thanks @jsoref
@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 7047e7d into jekyll:master Feb 1, 2023
jekyllbot added a commit that referenced this pull request Feb 1, 2023
@jekyllbot
Update history to reflect merge of #9199 [ci skip]
80f799b
github-actions bot pushed a commit that referenced this pull request Feb 1, 2023
@jekyllbot
Deploy docs from 7047e7d
ec2c866 
Josh Soref: Use check-spelling/check-spelling@v0.0.21 (#9199)

Merge pull request 9199
@jekyll jekyll locked and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ashmaroli ashmaroli ashmaroli approved these changes

Assignees

No one assigned

Labels

fix frozen-due-to-age internal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jsoref @ashmaroli @jekyllbot