Lock Ruby in CI to v3.1.2 and bump JRuby to v9.4.0.0#9196
Merged
Conversation
Member
Author
|
This issue could either be because of the |
parkr
approved these changes
Nov 27, 2022
| - label: JRuby 9.3.4.0 | ||
| ruby_version: "jruby-9.3.4.0" | ||
| - label: Ruby 3.1.2 | ||
| ruby_version: "3.1.2" |
Member
There was a problem hiding this comment.
What's our strategy/timeline for opening this back up to 3.1.x? Definitely don't want to fall behind...
Member
Author
There was a problem hiding this comment.
The plan is to manually monitor developments in the ruby_builder project repo and test on my personal fork of the Jekyll repo.
Update workflow here once the tests run successfully.
| - label: Ruby 3.1.2 | ||
| ruby_version: "3.1.2" | ||
| - label: JRuby 9.4.0.0 | ||
| ruby_version: "jruby-9.4.0.0" |
Member
|
I took a look at the commit diff for Ruby 3.1.3 from 3.1.2 and it was a mess of "merge revision X" commits so nothing to report so far (on mobile). |
Member
Author
|
Merging this for now. |
Member
Author
|
@jekyllbot: merge +dev |
jekyllbot
added a commit
that referenced
this pull request
Nov 27, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Nov 27, 2022
Ashwin Maroli: Lock Ruby in CI to v3.1.2 and bump JRuby to v9.4.0.0 (#9196) Merge pull request 9196
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Our CI appears to break on Ruby 3.1.3 in one of our PRs. Investigate with
mastercodebase.Context
Ruby 3.1.3 was shipped on 2022-11-24.