Skip to content

Update Jekyll on macOS (macos.md) and current ruby version to 3.1.3 in ruby.yml#9195

Merged
jekyllbot merged 2 commits intojekyll:masterfrom
masaki9:fix-docs-ruby-ver
Jan 4, 2023
Merged

Update Jekyll on macOS (macos.md) and current ruby version to 3.1.3 in ruby.yml#9195
jekyllbot merged 2 commits intojekyll:masterfrom
masaki9:fix-docs-ruby-ver

Conversation

@masaki9
Copy link
Copy Markdown
Contributor

@masaki9 masaki9 commented Nov 26, 2022

This is a 🔦 documentation change.

I've updated the current ruby version to 3.1.3 in ruby.yml to update the ruby version referenced in the Jekyll on macOS guide.

Summary

Ruby version 3.1.3 was released yesterday, November 24, 2022, and step 2 in the Jekyll on macOS guide currently references ruby version 3.1.2. The pull request change updates the current ruby version in ruby.yml to 3.1.3 from 3.1.2 to update the guide.

Context

Fixes #9194

@masaki9 masaki9 mentioned this pull request Dec 3, 2022
Closed
@postmodern
Copy link
Copy Markdown
Contributor

postmodern commented Dec 14, 2022

I was just about to submit my own issue or PR about this. Additionally, the documentation should not recommend ruby-install ruby as that will install the current stable version, which will soon be 3.2.0. If Jekyll requires ruby 3.1.x, then it should explicitly install it with ruby-install ruby-3.1 or ruby-install ruby-3.1.3.

@masaki9
Copy link
Copy Markdown
Contributor Author

masaki9 commented Dec 30, 2022

@postmodern I appreciate your comment. I just updated the doc to use ruby-install {{ site.data.ruby.current_version }}. It should show ruby-install ruby 3.1.3 instead of ruby-install ruby.

Ruby 3.2 was released on Dec 25, but I did not update the ruby version to 3.2 in ruby.yml as a few issues with ruby 3.2, such as #9231 and #9233 were reported for this project.

@masaki9 masaki9 changed the title Update current ruby version to 3.1.3 in ruby.yml Update Jekyll on macOS (macos.md) and current ruby version to 3.1.3 in ruby.yml Dec 30, 2022
@masaki9 masaki9 mentioned this pull request Dec 30, 2022
Closed
@ashmaroli
Copy link
Copy Markdown
Member

ashmaroli commented Dec 30, 2022

@masaki9 Are you able to install gem liquid-c on Ruby 3.1.3?

@masaki9
Copy link
Copy Markdown
Contributor Author

masaki9 commented Dec 31, 2022 •
edited
Loading

@ashmaroli I was able to install liquid-c on ruby 3.1.3 and macOS Monterey ver. 12.6, as shown in the attached screenshot. liquid-c does not seem to cause any issues. My site is running fine with it. Is there any known issue with ruby 3.1.3 and liquid-c?

liquid-c

@ashmaroli
Copy link
Copy Markdown
Member

ashmaroli commented Dec 31, 2022

Is there any known issue with ruby 3.1.3 and liquid-c?

liquid-c failed to install on our CI running on Linux (Ubuntu). Another user too reported being able to install successfully on macOS. So, until we get more input from the community, I'll see this as a linux-only issue.

@masaki9
Copy link
Copy Markdown
Contributor Author

masaki9 commented Jan 4, 2023 •
edited
Loading

@ashmaroli You are right. I set up a Ubuntu system and attempted to install liquid-c on Ruby 3.1.3. It fails on Ubuntu with Ruby 3.1.3, but it is OK on Ruby 3.1.2. I opened Shopify/liquid-c#185 for this issue.

This PR changes the Ruby version number to 3.1.3 in ruby.yml, which is used for macOS documentation and does not affect the Jekyll installation on Linux or your CI running Ubuntu. If you follow the Jekyll on Ubuntu guide, you will run sudo apt-get install ruby-full (which does not specify a Ruby version) and install Ruby 3.0.4 as of now.

Is your plan to wait till your CI works on Ruby 3.1.3?

@ashmaroli
Copy link
Copy Markdown
Member

ashmaroli commented Jan 4, 2023

Thank you @masaki9.
I was waiting for confirmation from the user-base that liquid-c fails to install on Linux / Ubuntu.
Now that you have provided the confirmation and got the ball rolling to have it addressed it source, this can be merged without further delay.

@jekyllbot: merge +doc

@jekyllbot jekyllbot merged commit bfa7c94 into jekyll:master Jan 4, 2023
jekyllbot added a commit that referenced this pull request Jan 4, 2023
@jekyllbot
Update history to reflect merge of #9195 [ci skip]
a891118
github-actions bot pushed a commit that referenced this pull request Jan 4, 2023
@jekyllbot
Deploy docs from bfa7c94
a8a208c 
masaki: Update Jekyll on macOS (macos.md) and current ruby version to 3.1.3 in ruby.yml (#9195)

Merge pull request 9195
@fabianrbz fabianrbz mentioned this pull request Mar 6, 2023
Merged
@barbarita1975 barbarita1975 linked an issue Mar 29, 2023 that may be closed by this pull request
[Docs]: cd1326d457123d7dab897913f7b3b070544a9332 #9329
Closed
barbarita1975
barbarita1975 reviewed Apr 1, 2023
View reviewed changes
Copy link
Copy Markdown

@barbarita1975 barbarita1975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jc

@jekyll jekyll locked and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ashmaroli ashmaroli ashmaroli approved these changes

+2 more reviewers

@barbarita1975 barbarita1975 barbarita1975 left review comments

@muzir muzir muzir approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation frozen-due-to-age

Projects

None yet

Milestone

No milestone

6 participants

@masaki9 @postmodern @ashmaroli @muzir @barbarita1975 @jekyllbot