Skip to content

Remove totals in profile table properly#9186

Merged
jekyllbot merged 2 commits intojekyll:masterfrom
ashmaroli:remove-profile-table-totals
Dec 18, 2022
Merged

Remove totals in profile table properly#9186
jekyllbot merged 2 commits intojekyll:masterfrom
ashmaroli:remove-profile-table-totals

Conversation

@ashmaroli
Copy link
Copy Markdown
Member

  • This is a 🐛 bug fix.

Summary

In #9039 I proposed to remove the TOTALS row but there were remnants that continued to generate and render info.
The current pull request removes all of such remnants.

Notes

  • Consider backporting this to the 4.3-stable branch.

@ashmaroli ashmaroli added fix backport-candidate Consider for merge into an older stable branch labels Nov 17, 2022
@ashmaroli ashmaroli requested a review from mattr- November 17, 2022 17:32
@ashmaroli
Copy link
Copy Markdown
Member Author

@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit 82bb271 into jekyll:master Dec 18, 2022
@jekyllbot jekyllbot added the bug label Dec 18, 2022
@ashmaroli ashmaroli deleted the remove-profile-table-totals branch December 18, 2022 13:14
jekyllbot added a commit that referenced this pull request Dec 18, 2022
github-actions bot pushed a commit that referenced this pull request Dec 18, 2022
Ashwin Maroli: Remove totals in profile table properly (#9186)

Merge pull request 9186
ashmaroli added a commit to ashmaroli/jekyll that referenced this pull request Jan 15, 2023
Remove totals in profile table properly
This backports 82bb271 to 4.3-stable
ashmaroli added a commit to ashmaroli/jekyll that referenced this pull request Jan 15, 2023
ashmaroli added a commit that referenced this pull request Jan 16, 2023
ashmaroli added a commit that referenced this pull request Jan 16, 2023
@jekyll jekyll locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport-candidate Consider for merge into an older stable branch bug fix frozen-due-to-age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants