Merged
Conversation
If on a system where system timezone is not +00, when tests are launched with 'script/test', test case "TestFilters#test_: filters jsonify filter should convert drop to json" fails due to difference in expected and actual value of 'date'. This difference equals the system timezone offset. Some other forms of lauching tests do work, such as 'script/test test/test_filters.rb'. Make the tests run correctly regardless of system timezone by setting TZ=UTC.
f3eefbb to
44bc0ef
Compare
Contributor
|
I have also stumbled upon this when running tests locally, that would be nice to get in! |
parkr
approved these changes
Nov 7, 2022
Member
|
Thanks @oturpe |
jekyllbot
added a commit
that referenced
this pull request
Nov 7, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Nov 7, 2022
Otto Liljalaakso: Run tests in UTC timezone (#9168) Merge pull request 9168
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a 🐛 bug fix.
script/cibuildto verify this)Summary
If on a system where system timezone is not +00,
when tests are launched with 'script/test', test case
"TestFilters#test_: filters jsonify filter should convert drop to json"
fails due to difference in expected and actual value of 'date'.
This difference equals the system timezone offset.
Some other forms of lauching tests do work,
such as 'script/test test/test_filters.rb'.
Make the tests run correctly regardless of system timezone
by setting TZ=UTC.
Context
Not related to a GitHub issue.