Fix import command parameters#910
Merged
parkr merged 1 commit intojekyll:masterfrom Apr 1, 2013
x3ro:fix-import-command-parameters
Merged
Fix import command parameters#910parkr merged 1 commit intojekyll:masterfrom x3ro:fix-import-command-parameters
parkr merged 1 commit intojekyll:masterfrom
x3ro:fix-import-command-parameters
Conversation
Apparently, the Commander gem treats options as boolean values when one does not indicate that a certain options is followed by a string. This led to the jekyll-import gem only receiving booleans instead of dbname/user/pwd...
parkr
added a commit
that referenced
this pull request
Apr 1, 2013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently, the Commander gem treats options as boolean values
when one does not indicate that a certain options is followed
by a string. This led to the jekyll-import gem only receiving
booleans instead of dbname/user/pwd...
Note: Haven't added a test for this, because I wasn't quite sure how I should go about writing a test for it. If someone would provide me with a pointer, I'd be happy to add a test as well.