Skip to content

Windows: describe which option to choose#9049

Merged
jekyllbot merged 2 commits intojekyll:masterfrom
kirstin:patch-1
Jun 20, 2022
Merged

Windows: describe which option to choose#9049
jekyllbot merged 2 commits intojekyll:masterfrom
kirstin:patch-1

Conversation

@kirstin
Copy link
Copy Markdown
Contributor

@kirstin kirstin commented Apr 29, 2022

This is a 🔦 documentation change.

Summary

I propose to install everything as I have no idea what shall be installed.
You have these options:

  • MSYS2
  • MSYS2 and MINGW development toolchain
    By proposing to install everything, I hope to create a discussion in case people know what to choose at this step.
    I chose the development toolchain so that compilation can take place.
    Is that correct?

Context

I propose to install everything as I have no idea what shall be installed.
You have these options:
- MSYS2
- MSYS2 and MINGW development toolchain
By proposing to install everything, I hope to create a discussion in case people know what to choose at this step.
I chose the development toolchain so that compilation can take place.
Copy link
Copy Markdown
Member

@mattr- mattr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jekyllbot: merge +docs

@mattr-
Copy link
Copy Markdown
Member

mattr- commented May 9, 2022

oh, right. jekyllbot doesn't respond to comments in reviews. I'll let CI finish running and then merge this.

@mattr-
Copy link
Copy Markdown
Member

mattr- commented May 9, 2022

@kirstin I just noticed that there's a spelling check error. Would you mind addressing that and updating your PR? You can add the word toolchain to .github/actions/spelling/expect.txt. Please add the word in alphabetical order.

@kirstin
Copy link
Copy Markdown
Contributor Author

kirstin commented May 14, 2022

Hi, I added a space between tool and chain. I think the dictionary should be fine with that now.

@parkr
Copy link
Copy Markdown
Member

parkr commented Jun 20, 2022

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 2536942 into jekyll:master Jun 20, 2022
jekyllbot added a commit that referenced this pull request Jun 20, 2022
github-actions bot pushed a commit that referenced this pull request Jun 20, 2022
Kirstin Heidler: Windows: describe which option to choose (#9049)

Merge pull request 9049
@parkr
Copy link
Copy Markdown
Member

parkr commented Jun 20, 2022

oh, right. jekyllbot doesn't respond to comments in reviews.

Now it does! jekyll/jekyllbot#17 😄

@jekyll jekyll locked and limited conversation to collaborators Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants