Skip to content

Ensure theme config is a Jekyll::Configuration object#8988

Merged
jekyllbot merged 1 commit intojekyll:masterfrom
ashmaroli:theme-config-jekyll-configuration-instance
Apr 8, 2022
Merged

Ensure theme config is a Jekyll::Configuration object#8988
jekyllbot merged 1 commit intojekyll:masterfrom
ashmaroli:theme-config-jekyll-configuration-instance

Conversation

@ashmaroli
Copy link
Copy Markdown
Member

  • This is a 🐛 bug fix.
  • I've added tests.

Summary

site.config merged with theme_config should continue responding to methods defined in Jekyll::Configuration class.

Context

Consider backporting to 4.2 series

@ashmaroli ashmaroli added backport-candidate Consider for merge into an older stable branch bug labels Mar 7, 2022
@ashmaroli ashmaroli requested review from mattr- and parkr March 21, 2022 14:52
@ashmaroli
Copy link
Copy Markdown
Member Author

ping @mattr-

@ashmaroli
Copy link
Copy Markdown
Member Author

@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit 3b3f845 into jekyll:master Apr 8, 2022
@jekyllbot jekyllbot added the fix label Apr 8, 2022
jekyllbot added a commit that referenced this pull request Apr 8, 2022
github-actions bot pushed a commit that referenced this pull request Apr 8, 2022
Ashwin Maroli: Ensure theme config is a `Jekyll::Configuration` object (#8988)

Merge pull request 8988
@jekyll jekyll locked and limited conversation to collaborators Apr 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport-candidate Consider for merge into an older stable branch bug fix frozen-due-to-age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants