Skip to content

Backport #8965 for v3.9.x: Fix response header for content served via jekyll serve#8976

Merged
ashmaroli merged 1 commit into3.9-stablefrom
3.9-stable-backport-8965
Feb 28, 2022
Merged

Backport #8965 for v3.9.x: Fix response header for content served via jekyll serve#8976
ashmaroli merged 1 commit into3.9-stablefrom
3.9-stable-backport-8965

Conversation

@parkr
Copy link
Copy Markdown
Member

@parkr parkr commented Feb 26, 2022

This PR back ports #8965 to the 3.9-stable branch. The motivation here is to fix issues with GitHub Pages without asking them to commit to upgrading to Jekyll v4. (github/pages-gem#695)

@parkr parkr added ⏪ backport Changes will be merged into an older stable branch fix labels Feb 26, 2022
@parkr parkr requested a review from ashmaroli February 27, 2022 07:18
@ashmaroli
Copy link
Copy Markdown
Member

@parkr the lib/jekyll/mime.types file has been updated multiple times since the time we migrated away from the 3.9-stable branch. Therefore, for consistency with the latest master, I recommend copy-pasting contents of the mime.types file from master onto this branch.

(Running script/vendor-mimes may pull in upstream changes that have not yet been incorporated into the master. Hence the recommendation for a copy-paste.)

@parkr parkr force-pushed the 3.9-stable-backport-8965 branch from c1f0077 to e7f53e6 Compare February 27, 2022 16:44
@parkr
Copy link
Copy Markdown
Member Author

parkr commented Feb 27, 2022

@ashmaroli Sounds good! I copied from the default branch and force-pushed up.

@ashmaroli ashmaroli changed the title Fix response header for content served via jekyll serve (backport of #8965) Backport #8965 for v3.9.x: Fix response header for content served via jekyll serve Feb 28, 2022
@ashmaroli ashmaroli merged commit 7e6769a into 3.9-stable Feb 28, 2022
@ashmaroli ashmaroli deleted the 3.9-stable-backport-8965 branch February 28, 2022 05:43
ashmaroli added a commit that referenced this pull request Feb 28, 2022
@jekyll jekyll locked and limited conversation to collaborators Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

fix frozen-due-to-age ⏪ backport Changes will be merged into an older stable branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants