Skip to content

Rewrite documentation on installing plugins#8921

Merged
jekyllbot merged 4 commits intomasterfrom
plugins-installation-doc
Jan 6, 2022
Merged

Rewrite documentation on installing plugins#8921
jekyllbot merged 4 commits intomasterfrom
plugins-installation-doc

Conversation

@ashmaroli
Copy link
Copy Markdown
Member

@ashmaroli ashmaroli commented Dec 30, 2021

  • This is a 🔦 documentation change.

Summary

Rewrite to reduce gotchas for a novice user working with plugins in their site

Context

Closes #8917
/cc @EmilySeville7cfg to provide feedback.
Preview URL

@ashmaroli ashmaroli requested review from a team, chrisfinazzo and mattr- and removed request for a team December 30, 2021 15:21
Copy link
Copy Markdown
Member

@mattr- mattr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great improvement on the previous documentation. Thanks!

I did suggest a small wording change and have a question about continuing to document the gems key.

## Using a Gemfile

The maintenance of various gem dependencies may be greatly simplified by using a Gemfile (usually at the root of site's source) in conjunction
with a Rubygem named `bundler`. The Gemfile however **should** list all the primary dependencies of your site, including Jekyll itself, not
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"...a Rubygem named Bundler"

Proper nouns FTW.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm choosing to leave this in lowercase because it references the actual gem-name (bundler) instead of the library.
However, the consequent mention has been corrected as requested.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm choosing to leave this in lowercase because it references the actual gem-name (bundler) instead of the library.

Got it. I was thinking about the distinction between Bundler (the project) v bundler (the executable which does a thing). See also Perl and perl.

Carry on.

Copy link
Copy Markdown
Contributor

@chrisfinazzo chrisfinazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes - see comments.

@ashmaroli
Copy link
Copy Markdown
Member Author

Thank you for the reviews @mattr- and @chrisfinazzo.
I have updated the document as requested.

@EmilyGraceSeville7cf
Copy link
Copy Markdown
Contributor

@ashmaroli, everything looks good. ;)

@ashmaroli ashmaroli requested a review from mattr- January 5, 2022 17:34
@ashmaroli
Copy link
Copy Markdown
Member Author

@jekyllbot: merge +doc

@jekyllbot jekyllbot merged commit b0a68d5 into master Jan 6, 2022
@jekyllbot jekyllbot deleted the plugins-installation-doc branch January 6, 2022 15:16
jekyllbot added a commit that referenced this pull request Jan 6, 2022
github-actions bot pushed a commit that referenced this pull request Jan 6, 2022
Ashwin Maroli: Rewrite documentation on installing plugins (#8921)

Merge pull request 8921
@jekyll jekyll locked and limited conversation to collaborators Jan 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs]: can't run site locally with plugin without changing Gemfile

6 participants