docs: Fix of a bug in the pagination section#8890
Merged
jekyllbot merged 1 commit intojekyll:masterfrom Sep 15, 2024
Merged
Conversation
There is a little bug in the laste code snippet in the pageination section. The link for the first page does not work when the `paginate_path` property points to a subfolder. In that case `{{ '/' | relative_url }}` points to the base url and ignores the subfolder.
I made a little demo which you can find [here](https://swagar.github.io/wrong-page1-link/blog/page2/). There you find the link for the first page twice. One with the old link und one with the new and working link.
You can finde the source code [here](https://github.com/swagar/wrong-page1-link/blob/master/blog/index.html#L38)
Member
|
Thanks @swagar |
jekyllbot
added a commit
that referenced
this pull request
Sep 15, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 15, 2024
Simon Wagar: Fix of a bug in the pagination section (#8890) Merge pull request 8890
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a little bug in the laste code snippet in the pageination section. The link for the first page does not work when the
paginate_pathproperty points to a subfolder. In that case{{ '/' | relative_url }}points to the base url and ignores the subfolder.I made a little demo which you can find here. There you find the link for the first page twice. One with the old link und one with the new and working link.
You can finde the source code here
Summary
Context