Fix random test failures in TestExcerpt #to_liquid#8884
Merged
jekyllbot merged 1 commit intojekyll:masterfrom Nov 17, 2021
Merged
Fix random test failures in TestExcerpt #to_liquid#8884jekyllbot merged 1 commit intojekyll:masterfrom
jekyllbot merged 1 commit intojekyll:masterfrom
Conversation
Failures can occur when the random seed orders TestFilters tests before
TestExcerpt and the tests are run with a system time zone that's has a
non-zero offset on 2013-07-22.
The TestFilters setup changes ENV["TZ"] to "UTC" but doesn't reset it.
The TestExcerpt#to_liquid test fails because @excerpt.to_liquid["date"]
returns a UTC time and Time.parse("2013-07-22") returns a time in the
system time zone:
Failure: TestExcerpt#test_: An extracted excerpt #to_liquid should
contain the proper page data to mimic the post liquid.
[jekyll/test/test_excerpt.rb:103] Minitest::Assertion:
Expected: 2013-07-22 00:00:00 +0000
Actual: 2013-07-22 00:00:00 +0100
Add a teardown to TestFilters to reset ENV["TZ"].
ashmaroli
approved these changes
Nov 17, 2021
Member
|
Thank you @philr |
jekyllbot
added a commit
that referenced
this pull request
Nov 17, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Nov 17, 2021
Phil Ross: Fix random test failures in TestExcerpt #to_liquid. (#8884) Merge pull request 8884
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a 🐛 bug fix.
Summary
Failures can occur in the
TestExcerpt#to_liquidtest when the random seed ordersTestFilterstests beforeTestExcerptand the tests are run with a system time zone that's has a non-zero offset on 2013-07-22.The
TestFilterssetup changesENV["TZ"]to"UTC"but doesn't reset it.The
TestExcerpt#to_liquidtest fails because@excerpt.to_liquid["date"]returns a UTC time andTime.parse("2013-07-22")returns a time in the system time zone:This pull request adds a teardown to
TestFiltersto resetENV["TZ"].