Skip to content

Improve document about Github Actions section#8853

Merged
jekyllbot merged 5 commits intojekyll:masterfrom
jeffreytse:patch-2
Apr 2, 2022
Merged

Improve document about Github Actions section#8853
jekyllbot merged 5 commits intojekyll:masterfrom
jeffreytse:patch-2

Conversation

@jeffreytse
Copy link
Copy Markdown
Contributor

This PR improves the section of GitHub actions for Jekyll users.

mattr-
mattr- previously requested changes Oct 23, 2021
Copy link
Copy Markdown
Member

@mattr- mattr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time and effort to update these docs! I've left a few suggestions I'd like you to address when you're able to.

@jeffreytse
Copy link
Copy Markdown
Contributor Author

Hi @mattr-

Firstly, hope you have a nice weekend. Are there any other issues on this PR? Or if you think it's not a good improvement, I will close it. : )

Thanks & Regards

Copy link
Copy Markdown
Member

@mattr- mattr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more small tweak and this will be ready to merge.

Thanks for sticking with it!

@mattr- mattr- dismissed their stale review March 24, 2022 15:58

Review comments have been addressed.

Co-authored-by: Matt Rogers <mattr-@github.com>
Copy link
Copy Markdown
Contributor Author

@jeffreytse jeffreytse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattr- Thank you! Now the small tweak is ready. Hope you have a good day! : )

@mattr-
Copy link
Copy Markdown
Member

mattr- commented Apr 2, 2022

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 6f31b36 into jekyll:master Apr 2, 2022
jekyllbot added a commit that referenced this pull request Apr 2, 2022
github-actions bot pushed a commit that referenced this pull request Apr 2, 2022
JT: Improve document about Github Actions section (#8853)

Merge pull request 8853
@jekyll jekyll locked and limited conversation to collaborators Apr 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants