Remove the warning about auto-regeneration on Windows#8821
Merged
Conversation
Member
|
AFAICT aren't only bug-fixes, security-fixes and removal of regressions backported in Jekyll? I don't see a need for documentation or tests on this one. |
Member
Author
yes please 😄 |
ashmaroli
approved these changes
Sep 23, 2021
Member
|
Thanks @mattr- 😃 |
jekyllbot
added a commit
that referenced
this pull request
Sep 23, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Sep 23, 2021
Matt Rogers: Remove the warning about auto-regeneration on Windows (#8821) Merge pull request 8821
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a 🙋 feature or enhancement.
Summary
This removes the warning about auto regeneration on Windows potentially having problems. According to the info in #8820, the bug we're calling out is four years old and I don't think that it's in our best interest to continue support installations using WSL that are running software that old. I'd rather remove this warning and handle a few extra questions from folks in these scenarios and encourage them to upgrade instead.
Context
Fixes #8820
Potential 4.2 backport candidate?