Always hide cache-dir contents from Git#8798
Merged
jekyllbot merged 2 commits intojekyll:masterfrom Sep 16, 2021
Merged
Conversation
Member
Author
|
@jekyllbot: merge +minor |
jekyllbot
added a commit
that referenced
this pull request
Sep 16, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Sep 16, 2021
Ashwin Maroli: Always hide cache-dir contents from Git (#8798) Merge pull request 8798
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cache-dir and its contents shouldn't be tracked by version control even if users do not add the directory to their
.gitignorefile.Context
Currently, while
jekyll newgenerates a new site with.jekyll-cacheadded to the.gitignore, existing sites using Jekyll 3 on migrating to Jekyll 4 will have to manually update their.gitignorefile as well.Similarly, users on Jekyll 4 but opting to use a custom cache-dir location will also have to manually update their
.gitignorefile.Additionally, Jekyll contributors switching between
master(or any recent branch) and3.9-stable(and older) will also have to manually handle cache dir contents because the.gitignorefiles in older checkouts do not ignore.jekyll-cache.This pull request resolves the above UX hiccups.