Fix regression in Convertible module from v4.2.0 #8786
Merged
jekyllbot merged 2 commits intojekyll:masterfrom Aug 29, 2021
Merged
Fix regression in Convertible module from v4.2.0 #8786jekyllbot merged 2 commits intojekyll:masterfrom
jekyllbot merged 2 commits intojekyll:masterfrom
Conversation
mattr-
approved these changes
Aug 27, 2021
Member
mattr-
left a comment
There was a problem hiding this comment.
Looks good to me.
I also agree with a backport to the 4.2 branch.
Member
Author
|
@jekyllbot: merge +fix |
jekyllbot
added a commit
that referenced
this pull request
Aug 29, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Aug 29, 2021
Ashwin Maroli: Fix regression in Convertible module from v4.2.0 (#8786) Merge pull request 8786
ashmaroli
added a commit
to ashmaroli/jekyll
that referenced
this pull request
Aug 29, 2021
Fix regression in Convertible module from v4.2.0 This backports eca4504 to 4.2-stable
ashmaroli
added a commit
that referenced
this pull request
Sep 16, 2021
This was referenced Aug 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts a change intended to optimize allocations of Hash objects from
Convertible#to_liquidin v4.2.0.Adds a Cucumber scenario to reproduce the regression with current
masteror Jekyll 4.2.0Context
Ref: #6467 (comment) by @pdmosses
Backport this to
4.2-stableand include in v4.2.1 ?