@jjnilton This needs a test coverage as well.
Moreover, why is the excerpt drop method basename instead of name?

@ashmaroli sorry for taking so long to reply here.

I think I will need some help with the tests. I searched the code to find some test examples with the path and relative_path methods and seems that this needs tests in test_excerpt and test_filters, but I'm not sure.

My thinking was that excerpt should be like the document, so the methods have the same name, and since excerpt_drop inherits from document_drop, both would have the basename and name.

@jjnilton First of all DocumentDrop instances do not respond to :basename, only Document instances do.
With your change, DocumentDrop instances will now respond to :name but still not :basename (because of the delegation). Therefore, ExcerptDrop instances need not respond to :basename as well.

Hope I was able to clear that fog.

Regarding tests, since you are only improving exposed Liquid attributes for documents (also posts), the best location to add a test would be in features/post_data.feature. Follow the pattern used in existing scenarios in that file and add a new scenario to test if using {{ page.name }} produces the expected results and resolves your concern in #8699

ping @jjnilton

@ashmaroli sorry for taking so long to reply (again), and thanks for the explanations.

With your change, DocumentDrop instances will now respond to :name but still not :basename (because of the delegation)
Therefore, ExcerptDrop instances need not respond to :basename as well.

I changed the excerpt.rb part to this:

    # The base filename of the excerpt.
    #
    # Returns the base filename for the doc this excerpt belongs.
    def basename
      @basename ||= File.join(doc.basename, "#excerpt")
    end

And it does not return the basename in the exercepts with {{ page.basename }}, only with {{ page.name}}.

Adding to document_drob.rb makes it return for both.:

      delegate_methods :id, :output, :content, :to_s, :relative_path, :url, :date, :basename

If I don't use basename for name of the method in excerpt.rb I get this error when trying to run jekyll:

jekyll/lib/jekyll/drops/drop.rb:72:in block in delegate_method_as': undefined method basename' for #Jekyll::Excerpt:0x000055d786320c18 (NoMethodError)

I think that I've slowed down this fix, so if you or someone else want continue, please do. Maybe it'll help me understand how it should be done.

If I don't use basename for name of the method in excerpt.rb. I get this error when trying to run jekyll..

I've left a suggestion in the review.

Plus, if you don't wish to continue working on this, feel free to close this PR.
I'll submit a fresh one from latest master.

Updated with the suggestion but it throws that error during the tests:

Error:
TestExcerptDrop#test_: an excerpt drop should be inspectable. :
NoMethodError: undefined method `basename' for <Jekyll::Excerpt id=/publish_test/2008/02/02/published#excerpt>:Jekyll::Excerpt
    /home/jj/Downloads/giveup/jekyll-1/lib/jekyll/drops/drop.rb:72:in `block in delegate_method_as'

There are other failures too, but it seems they appear even on a fresh clone from master without modifications.

Updated with the suggestion but it throws that error during the tests..

My bad! I did not notice that you added the definition to excerpt.rb instead of drops/excerpt/drop.rb.
I've made the necessary switch.

Thanks @jjnilton
@jekyllbot: merge +minor