Inject livereload script using location.protocol instead of http:#8718
Merged
jekyllbot merged 1 commit intojekyll:masterfrom Jul 23, 2021
Merged
Inject livereload script using location.protocol instead of http:#8718jekyllbot merged 1 commit intojekyll:masterfrom
location.protocol instead of http:#8718jekyllbot merged 1 commit intojekyll:masterfrom
Conversation
mattr-
approved these changes
Jul 22, 2021
DirtyF
approved these changes
Jul 23, 2021
Member
|
@jekyll: merge +fix |
jekyllbot
added a commit
that referenced
this pull request
Jul 23, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Jul 23, 2021
Aram Akhavan: use location.protocol to inject the livereload script instead of forcing http (#8718) Merge pull request 8718
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a 🐛 bug fix.
Summary
If you run
jekyll serve --livereloadbehind an ssl-terminating reverse proxy (or, presumably, using jekyll's own ssl options), the livereload script gets loaded overhttp. Browsers like Firefox will reject this mixed content load.Instead of forcing the injection to use
http, this change useslocation.protocolwhich dynamically chooseshttporhttpsdepending on the URL in the browser.This API is well supported: https://caniuse.com/mdn-api_location_protocol