Skip to content

Revert "style: run rubocop -a"#8676

Merged
jekyllbot merged 1 commit intojekyll:masterfrom
kmk3:revert-run-rubocop-112
May 16, 2021
Merged

Revert "style: run rubocop -a"#8676
jekyllbot merged 1 commit intojekyll:masterfrom
kmk3:revert-run-rubocop-112

Conversation

@kmk3
Copy link
Copy Markdown
Contributor

@kmk3 kmk3 commented May 16, 2021

This is a 🐛 bug fix.

Summary

This reverts commit 5631170.

It fixes a warning when using Ruby 3.0, but brings about another one
when using Ruby 2.5, which is what ci uses. From the logs of that
commit's workflow run[1]:

+style-check | RUBY=2.5
+style-check | --> RUN script/fmt
+style-check | RuboCop 1.12.1
+style-check | The following cops were added to RuboCop, but are not configured. Please set Enabled to either `true` or `false` in your `.rubocop.yml` file.

+style-check | Please also note that can also opt-in to new cops by default by adding this to your config:
+style-check |   AllCops:
+style-check |     NewCops: enable
+style-check | Minitest/AssertWithExpectedArgument: # (new in 0.11)
+style-check |   Enabled: true
+style-check | Performance/MapCompact: # (new in 1.11)
+style-check |   Enabled: true
+style-check | Performance/RedundantEqualityComparisonBlock: # (new in 1.10)
+style-check |   Enabled: true
+style-check | Performance/RedundantSplitRegexpArgument: # (new in 1.10)
+style-check |   Enabled: true
+style-check | For more information: https://docs.rubocop.org/rubocop/versioning.html
+style-check | Inspecting 134 files
+style-check | .C....................................................................................................................................

+style-check | Offenses:

+style-check | lib/jekyll/cache.rb:170:23: C: Security/MarshalLoad: Avoid using Marshal.load.
+style-check |       value = Marshal.load(cached_file)
+style-check |                       ^^^^

+style-check | 134 files inspected, 1 offense detected

+style-check | Try running `script/fmt -a` to automatically fix errors
+style-check |
+style-check | Command /bin/sh -c script/fmt failed with exit code 1
+style-check |
+style-check | ERROR: Command exited with non-zero code: RUN script/fmt

[1] https://github.com/jekyll/jekyll/runs/2586877102

Context

Relates to #8654.

@kmk3 kmk3 marked this pull request as ready for review May 16, 2021 13:48
This reverts commit 5631170.

It fixes a warning when using Ruby 3.0, but brings about another one
when using Ruby 2.5, which is what ci uses.  From the logs of that
commit's workflow run[1]:

    +style-check | RUBY=2.5
    +style-check | --> RUN script/fmt
    +style-check | RuboCop 1.12.1
    +style-check | The following cops were added to RuboCop, but are not configured. Please set Enabled to either `true` or `false` in your `.rubocop.yml` file.

    +style-check | Please also note that can also opt-in to new cops by default by adding this to your config:
    +style-check |   AllCops:
    +style-check |     NewCops: enable
    +style-check | Minitest/AssertWithExpectedArgument: # (new in 0.11)
    +style-check |   Enabled: true
    +style-check | Performance/MapCompact: # (new in 1.11)
    +style-check |   Enabled: true
    +style-check | Performance/RedundantEqualityComparisonBlock: # (new in 1.10)
    +style-check |   Enabled: true
    +style-check | Performance/RedundantSplitRegexpArgument: # (new in 1.10)
    +style-check |   Enabled: true
    +style-check | For more information: https://docs.rubocop.org/rubocop/versioning.html
    +style-check | Inspecting 134 files
    +style-check | .C....................................................................................................................................

    +style-check | Offenses:

    +style-check | lib/jekyll/cache.rb:170:23: C: Security/MarshalLoad: Avoid using Marshal.load.
    +style-check |       value = Marshal.load(cached_file)
    +style-check |                       ^^^^

    +style-check | 134 files inspected, 1 offense detected

    +style-check | Try running `script/fmt -a` to automatically fix errors
    +style-check |
    +style-check | Command /bin/sh -c script/fmt failed with exit code 1
    +style-check |
    +style-check | ERROR: Command exited with non-zero code: RUN script/fmt

[1] https://github.com/jekyll/jekyll/runs/2586877102
@DirtyF
Copy link
Copy Markdown
Member

DirtyF commented May 16, 2021

@jekyll: merge +fix

@jekyllbot jekyllbot merged commit 7e350ac into jekyll:master May 16, 2021
jekyllbot added a commit that referenced this pull request May 16, 2021
github-actions bot pushed a commit that referenced this pull request May 16, 2021
Kelvin M. Klann: Revert "style: run rubocop -a" (#8676)

Merge pull request 8676
@kmk3 kmk3 deleted the revert-run-rubocop-112 branch May 16, 2021 20:12
@jekyll jekyll deleted a comment from github-actions bot May 20, 2021
@jekyll jekyll locked and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants