Revert "style: run rubocop -a"#8676
Merged
jekyllbot merged 1 commit intojekyll:masterfrom May 16, 2021
Merged
Conversation
This reverts commit 5631170. It fixes a warning when using Ruby 3.0, but brings about another one when using Ruby 2.5, which is what ci uses. From the logs of that commit's workflow run[1]: +style-check | RUBY=2.5 +style-check | --> RUN script/fmt +style-check | RuboCop 1.12.1 +style-check | The following cops were added to RuboCop, but are not configured. Please set Enabled to either `true` or `false` in your `.rubocop.yml` file. +style-check | Please also note that can also opt-in to new cops by default by adding this to your config: +style-check | AllCops: +style-check | NewCops: enable +style-check | Minitest/AssertWithExpectedArgument: # (new in 0.11) +style-check | Enabled: true +style-check | Performance/MapCompact: # (new in 1.11) +style-check | Enabled: true +style-check | Performance/RedundantEqualityComparisonBlock: # (new in 1.10) +style-check | Enabled: true +style-check | Performance/RedundantSplitRegexpArgument: # (new in 1.10) +style-check | Enabled: true +style-check | For more information: https://docs.rubocop.org/rubocop/versioning.html +style-check | Inspecting 134 files +style-check | .C.................................................................................................................................... +style-check | Offenses: +style-check | lib/jekyll/cache.rb:170:23: C: Security/MarshalLoad: Avoid using Marshal.load. +style-check | value = Marshal.load(cached_file) +style-check | ^^^^ +style-check | 134 files inspected, 1 offense detected +style-check | Try running `script/fmt -a` to automatically fix errors +style-check | +style-check | Command /bin/sh -c script/fmt failed with exit code 1 +style-check | +style-check | ERROR: Command exited with non-zero code: RUN script/fmt [1] https://github.com/jekyll/jekyll/runs/2586877102
ca8ba7d to
904a71a
Compare
This was referenced May 16, 2021
DirtyF
approved these changes
May 16, 2021
Member
|
@jekyll: merge +fix |
jekyllbot
added a commit
that referenced
this pull request
May 16, 2021
github-actions bot
pushed a commit
that referenced
this pull request
May 16, 2021
Kelvin M. Klann: Revert "style: run rubocop -a" (#8676) Merge pull request 8676
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a 🐛 bug fix.
Summary
This reverts commit 5631170.
It fixes a warning when using Ruby 3.0, but brings about another one
when using Ruby 2.5, which is what ci uses. From the logs of that
commit's workflow run[1]:
[1] https://github.com/jekyll/jekyll/runs/2586877102
Context
Relates to #8654.