Tags:Highlight: Decomposed HTMLLegacy formatter#8623
Merged
jekyllbot merged 1 commit intojekyll:masterfrom Aug 9, 2021
rsampaths16:master
Merged
Tags:Highlight: Decomposed HTMLLegacy formatter#8623jekyllbot merged 1 commit intojekyll:masterfrom rsampaths16:master
jekyllbot merged 1 commit intojekyll:masterfrom
rsampaths16:master
Conversation
Decomposed HTMLLegacy formatter to appropriate sequence of formatters. I was verifying approaches for #8621 and discovered that render_rouge was not open for extension. Moved away from HTMLLegacy so it becomes extensible. Reference: * https://github.com/rouge-ruby/rouge/blob/master/lib/rouge/formatters/html_legacy.rb#L27-L37 * #8621
Member
|
@jekyll merge +dev |
Member
|
@jekyllbot: merge +dev |
jekyllbot
added a commit
that referenced
this pull request
Aug 9, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Aug 9, 2021
Sampath Sukesh Ravolaparthi: Tags:Highlight: Decomposed HTMLLegacy formatter (#8623) Merge pull request 8623
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a 🔨 code refactoring.
Summary
I've decomposed
HTMLLegacyformatter to appropriate sequence of formatters in thehighlighttag.Context
I was verifying approaches for #8621 and discovered that
render_rougewas not open for extension. Moved away fromHTMLLegacyso it becomes extensible. No change in actual functionality.Reference: