Cross Version Testing Locally and Faster CI#8610
Merged
jekyllbot merged 2 commits intojekyll:masterfrom Mar 26, 2021
Merged
Conversation
adamgordonbell
commented
Mar 22, 2021
adamgordonbell
commented
Mar 22, 2021
mattr-
approved these changes
Mar 23, 2021
Member
mattr-
left a comment
There was a problem hiding this comment.
This looks fantastic. I left a whitespace nit that I would appreciate a fix for but won't let that block the PR
Contributor
Author
You are too kind. Thanks for the review! I adjusted the whitespace. |
Contributor
Author
|
I believe this is ready to merge by someone with permission to do so. |
Member
|
@jekyllbot: merge +dev |
jekyllbot
added a commit
that referenced
this pull request
Mar 26, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Mar 26, 2021
Adam Bell: Cross Version Testing Locally and Faster CI (#8610) Merge pull request 8610
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a 🙋 feature or enhancement to the build process. Jekyll itself is unchanged.
Summary
Introduce earthly to speed up JRuby tests and allow for running the CI locally across various ruby versions. This build should be about 10 minutes faster than the previous build (40+ minutes -> 27ish minutes).
I discussed this change with @DirtyF via email.
The JRuby build in GitHub Actions is the bottleneck for the CI process. By introducing an earthfile, the step can be optimized a bit, and also it allows for running the CI locally, across various ruby versions, by using containers.
Details
You can now run the full CI locally by running:
GitHub Actions also does a similar process, although it calls individual steps, which can also be run locally like follows:
I believe the build can be made a bit faster than this, by running the jruby cucumber tests in parallel. This will add a little complexity to the build script and probably take another 10 minutes off. Let me know if interested and I can try it out and create a follow on PR.
Additionally, one cucumber test was failing in master, I believe I have fixed it.