Load Jekyll plugins from BUNDLE_GEMFILE location#8585
Merged
jekyllbot merged 1 commit intojekyll:masterfrom May 16, 2021
Merged
Load Jekyll plugins from BUNDLE_GEMFILE location#8585jekyllbot merged 1 commit intojekyll:masterfrom
jekyllbot merged 1 commit intojekyll:masterfrom
Conversation
DirtyF
approved these changes
Mar 26, 2021
Member
|
@jekyll: merge +fix |
jekyllbot
added a commit
that referenced
this pull request
May 16, 2021
github-actions bot
pushed a commit
that referenced
this pull request
May 16, 2021
Liam Bigelow: Load Jekyll plugins from BUNDLE_GEMFILE location (#8585) Merge pull request 8585
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a 🐛 bug fix.
Summary
Before telling bundler to load plugins in the
:jekyll_pluginsgroup,plugin_manager.rbchecks for the existence of a Gemfile in the current working directory.In some setups, the Gemfile may live elsewhere and be referenced using the
BUNDLE_GEMFILEenvironment variable. In this case, the Gemfile check will fail and the:jekyll_pluginsgroup will not be loaded.Bundler is aware of the file (since the gems still resolve), so all we need to do is expand the check for a Gemfile to include the BUNDLE_GEMFILE environment variable.
Reproduction
For a given Jekyll site with plugins referenced in the Gemfile and not in the _config.yml, run the following in the parent directory:
The plugins in the Gemfile plugins group will not be loaded.
Context
I haven't found an existing issue or PR referencing this.