Skip to content

typo - do instead of don't#8518

Merged
jekyllbot merged 3 commits intojekyll:masterfrom
catherinetsang:patch-1
Dec 31, 2020
Merged

typo - do instead of don't#8518
jekyllbot merged 3 commits intojekyll:masterfrom
catherinetsang:patch-1

Conversation

@catherinetsang
Copy link
Copy Markdown
Contributor

Summary

Context

@ashmaroli
Copy link
Copy Markdown
Member

@catherinetsang Thank you for improving our docs.
Though the change is fine as is, I now realize that the paragraph itself doesn't flow smoothly while reading.

Will you be able to rephrase the whole paragraph to read better? If not, this will get merged anyways.

@catherinetsang
Copy link
Copy Markdown
Contributor Author

@ashmaroli Sure thing. Let me try to rephrase it

Added a bit more detail to make it beginner friendly, tried to include where the BOM is located and a hyperlink to see what the byte sequence could look like
Copy link
Copy Markdown
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @catherinetsang 🙏🏻

@DirtyF
Copy link
Copy Markdown
Member

DirtyF commented Dec 31, 2020

@jekyll: merge +docs

@jekyllbot jekyllbot merged commit 52fd945 into jekyll:master Dec 31, 2020
jekyllbot added a commit that referenced this pull request Dec 31, 2020
github-actions bot pushed a commit to tigefa4u/jekyll that referenced this pull request Dec 31, 2020
jekyllbot: Update history to reflect merge of jekyll#8518 [ci skip]
github-actions bot pushed a commit that referenced this pull request Dec 31, 2020
Curious Cat: typo - do instead of don't (#8518)

Merge pull request 8518
@jekyll jekyll locked and limited conversation to collaborators Dec 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants