Only enable BOM encoding option on UTF encodings#8363
Merged
jekyllbot merged 1 commit intojekyll:masterfrom Apr 1, 2022
Merged
Only enable BOM encoding option on UTF encodings#8363jekyllbot merged 1 commit intojekyll:masterfrom
jekyllbot merged 1 commit intojekyll:masterfrom
Conversation
ffda574 to
a560461
Compare
Ruby does not allow the BOM option on non-UTF encodings, warning that it is "nonsense". To remove this warning, we change the BOM option check here to match how Ruby checks for compatible encodings. Relevant bits from the Ruby source are the test: https://github.com/ruby/ruby/blob/ruby_2_7/io.c#L5693-L5699 and the `utf_prefix` string: https://github.com/ruby/ruby/blob/ruby_2_7/io.c#L5454 Fixes jekyll#7972.
a560461 to
619e86d
Compare
Member
|
Thanks @LinuxMercedes |
jekyllbot
added a commit
that referenced
this pull request
Apr 1, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Apr 1, 2022
lm: Only enable BOM encoding option on UTF encodings (#8363) Merge pull request 8363
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a 🐛 bug fix.
Summary
Ruby does not allow the BOM option on non-UTF encodings, warning that it is "nonsense". To remove this warning, we change the BOM option check here to match how Ruby checks for compatible encodings.
Relevant bits from the Ruby source are the test and the
utf_prefixstring.Context
Fixes #7972.