Conversation
|
Hello @danielhaim1, thank you for submitting this PR. Line 8 in 6afaa36 |
- Converted 4 indent to 2 indent - Added `font-display: swap` to FontAwesome
|
|
I see a lot of unnecessary changes like changing double-quotes to single-quotes, removal of comments and other whitespace changes. Please limit the amount of changes to just those that are actually necessary. |
I updated `docs/_sass/_fonts.scss` with improved comments. The original comments were removed because they were incorrect. Lato (300) is `Lato Light`, but stated as `lato-300 latin`
|
@ashmaroli thanks for reviewing again. I updated In other cases, I converted inline CSS comments ( In other changes, I've sorted the CSS properties with each selector declaration in a predefined order to be as close as possible to the browser engine. |
|
You're welcome. Understandably, the amount of changes increases the amount of time for reviewing. You can help us out by going through the |
|
@ashmaroli reverting the files back to normal, and only added my most critical changes. |
|
Let me know if you'd like me to comb the file again, it saves approx ~300 lines. |
danielhaim1
left a comment
There was a problem hiding this comment.
Reverted, looks good to me.
genuinemoses
left a comment
There was a problem hiding this comment.
Every change looks good.
@devMoses Um.. I don't see the revert commit here. |
DirtyF
left a comment
There was a problem hiding this comment.
This looks good to me, thanks, and sorry for the late review :)
|
@jekyll: merge +site |


This is a 🔦 documentation change.
Summary
General improvements to the stylesheet used for Jekyll documentations.
Latotext-renderingoptionfont-rules (fall backs)Improved order of CSS propertiesTested on multiple pages.