Remove configuration of theme sass files from Core#7290
Merged
jekyllbot merged 7 commits intojekyll:masterfrom Aug 14, 2019
Merged
Remove configuration of theme sass files from Core#7290jekyllbot merged 7 commits intojekyll:masterfrom
jekyllbot merged 7 commits intojekyll:masterfrom
Conversation
mattr-
reviewed
May 10, 2019
Member
mattr-
left a comment
There was a problem hiding this comment.
Agree in principle. I need to see CI pass first before final approval.
Member
|
What can we do to get this fixed up? I'd still like to ship this for 4.0. |
DirtyF
approved these changes
Aug 13, 2019
Member
|
@jekyllbot: merge +fix |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Thank you @DirtyF 🎉 😃 |
Member
|
Thank YOU @ashmaroli 💪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Configuring Sass from theme-gem should be handled by the bundled
jekyll-sass-converterpluginContext
So that when the converter plugin chooses to drop support for
sass-ruby, Jekyll wouldn't care..Requirements
jekyll-sass-converterplugin (Configure Sass to load from theme-gem if possible jekyll-sass-converter#80)jekyll-sass-converterships a new version containing the "function"