Conversation
|
You can find a built version these docs here. |
DirtyF
left a comment
There was a problem hiding this comment.
Great work, Showcase could use some lazyloading or pagination, but we can tackle this later.
|
@mneumegen I didn't compare the two sitemaps, but looks there are not so much redirections from actual URLs to handle, also Docsearch will quickly index the new site, so search shouldn't be impacted more than 24 hours. |
ghost
left a comment
There was a problem hiding this comment.
thanks for this! one request, we have a team page at /team that isn't linked anywhere. could you link it somewhere, maybe in the header or the footer? thanks!
anyways, here's my painstakingly long review
This comment has been minimized.
This comment has been minimized.
|
@ashmaroli What did you have in mind for pagination? The examples are pretty verbose but that's just the nature of using that plugin. |
* normalize markup indentation * fold long lines in code examples to the following line to improve readability
@mneumegen I have made the changes myself, to avoid polluting this PR with unnecessary discussions.. |
docs/_docs/pagination.md
Outdated
| </a> | ||
| {% else %} | ||
| <a href="{{ site.paginate_path | prepend: site.baseurl | replace: '//', '/' | replace: ':num', page }}">{{ page }}</a> | ||
| <a href="{{ site.paginate_path | relative_url }}">{{ page }}</a> |
There was a problem hiding this comment.
what about the last replace filter here?
ghost
left a comment
There was a problem hiding this comment.
Don't wanna stop this massive PR from landing, we can make smaller changes afterwards.
|
@mneumegen great work Mike! Apologies I wasn't able to provide much feedback |
|
@jekyllbot: |
+docs
Large overhaul of the docs.
This PR is my attempt to: