Add Lyrics button to right-controls. #1363
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a microphone icon to the right-controls for easier accessibility to a songs lyrics. It opens the fullscreenplayer and switches to the lyrics tab. This brings Feishin more in line with applications such as Spotify and Deezer that has a dedicated Lyric button in the player bar for easy access to a songs lyrics.
Adds:
Missing:
Preview: (File exceeded githubs 10mb limit, uploaded to streamable)
https://streamable.com/wcw2j9
Notes:
I have not tried building this, only local testing in dev.
I am not a react dev, so if you don't feel this is acceptable that's fine, I tried to keep the same structure as other places in the code. I do feel that a feature like this would be much appreciated :)