Skip to content

Conversation

@lindenkron
Copy link
Contributor

Adds a microphone icon to the right-controls for easier accessibility to a songs lyrics. It opens the fullscreenplayer and switches to the lyrics tab. This brings Feishin more in line with applications such as Spotify and Deezer that has a dedicated Lyric button in the player bar for easy access to a songs lyrics.

Adds:

  • Microphone icon to right controls
  • Switches automatically to lyrics tab in fullscreenplayer
  • Changes button color to 'primary' when lyrics are active

Missing:

  • Other locals than 'en.json' (I assume that's the default)
  • Possibly a settings state saving, unsure how Feishin handles that (or if its necessary)

Preview: (File exceeded githubs 10mb limit, uploaded to streamable)
https://streamable.com/wcw2j9

Notes:
I have not tried building this, only local testing in dev.
I am not a react dev, so if you don't feel this is acceptable that's fine, I tried to keep the same structure as other places in the code. I do feel that a feature like this would be much appreciated :)

@vercel
Copy link

vercel bot commented Dec 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
feishin Error Error Dec 10, 2025 8:49pm

@jeffvli jeffvli merged commit bb55fc2 into jeffvli:development Dec 11, 2025
6 checks passed
iiPythonx pushed a commit to iiPythonx/feishin that referenced this pull request Dec 13, 2025
* Add Microphone icon to right-controls to show/hide lyrics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants