feat: build no-YJIT Linux variants for older glibc systems#11
Merged
Conversation
Build both YJIT and no-YJIT variants on Linux runners. The YJIT builds require glibc 2.35+ while no-YJIT builds target glibc 2.13 (x86_64) / 2.17 (ARM), supporting older distros like RHEL 7, Amazon Linux 2, and CentOS 7. Output tarballs: - ruby-X.Y.Z.x86_64_linux.tar.gz (YJIT, unchanged) - ruby-X.Y.Z.no_yjit.x86_64_linux.tar.gz (no YJIT, new) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
glibc@2.13 causes OpenSSL header incompatibilities with portable-openssl@3.5.1 (opaque X509 struct access). CentOS 6 (glibc 2.12) has been EOL since 2020; all supported distros (RHEL 7, AL2, etc.) have glibc >= 2.17. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
| on_arm do | ||
| depends_on "glibc@2.17" => :build | ||
| end | ||
| depends_on "glibc@2.17" => :build |
There was a problem hiding this comment.
x86_64 glibc version contradicts PR description target
Medium Severity
The PR description explicitly states "No-YJIT builds target glibc 2.13 (x86_64) / 2.17 (ARM)" but the code change removes the architecture-specific glibc dependencies and uses glibc@2.17 for both architectures. The original code had on_intel using glibc@2.13 and on_arm using glibc@2.17. This means x86_64 no-YJIT builds will now require glibc 2.17 instead of 2.13, reducing compatibility with older x86_64 systems.
Additional Locations (2)
4 tasks
jdx
added a commit
to jdx/mise
that referenced
this pull request
Feb 9, 2026
## Summary - On Linux with glibc < 2.35, automatically download the no-YJIT precompiled Ruby variant from jdx/ruby - YJIT builds require glibc 2.35+ (Ubuntu 22.04+, Debian 12+, Fedora 36+) - No-YJIT builds target glibc 2.17, supporting older distros (RHEL 7, Amazon Linux 2, CentOS 7) - Detects glibc version via `ldd --version`, cached for the process lifetime - Falls back to standard YJIT build if no no-YJIT variant exists for the requested version Depends on jdx/ruby#11 which adds no-YJIT Linux variants to the release pipeline. ## Test plan - [ ] On glibc 2.35+ system: installs standard YJIT build (unchanged behavior) - [ ] On glibc < 2.35 system: installs `.no_yjit.` variant - [ ] On glibc < 2.35 with version that has no no-YJIT variant: falls back to standard build - [ ] On macOS: unchanged behavior (always YJIT) 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Changes runtime platform detection and alters which Ruby tarball is downloaded on Linux, which could cause install failures on edge cases (missing `ldd`, non-glibc systems, or unexpected `ldd --version` output). > > **Overview** > Precompiled Ruby installs now *auto-select* the `.no_yjit` release asset on Linux when detected glibc is older than 2.35, with fallback to the standard precompiled build if the variant isn’t available. > > This adds a process-wide glibc version detector (`LINUX_GLIBC_VERSION` via `ldd --version`) and updates the Ruby plugin’s GitHub release asset selection and download filename handling to support the no-YJIT artifact naming. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 8804fe6. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
lucasew
pushed a commit
to lucasew/CONTRIB-mise
that referenced
this pull request
Feb 18, 2026
## Summary - On Linux with glibc < 2.35, automatically download the no-YJIT precompiled Ruby variant from jdx/ruby - YJIT builds require glibc 2.35+ (Ubuntu 22.04+, Debian 12+, Fedora 36+) - No-YJIT builds target glibc 2.17, supporting older distros (RHEL 7, Amazon Linux 2, CentOS 7) - Detects glibc version via `ldd --version`, cached for the process lifetime - Falls back to standard YJIT build if no no-YJIT variant exists for the requested version Depends on jdx/ruby#11 which adds no-YJIT Linux variants to the release pipeline. ## Test plan - [ ] On glibc 2.35+ system: installs standard YJIT build (unchanged behavior) - [ ] On glibc < 2.35 system: installs `.no_yjit.` variant - [ ] On glibc < 2.35 with version that has no no-YJIT variant: falls back to standard build - [ ] On macOS: unchanged behavior (always YJIT) 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Changes runtime platform detection and alters which Ruby tarball is downloaded on Linux, which could cause install failures on edge cases (missing `ldd`, non-glibc systems, or unexpected `ldd --version` output). > > **Overview** > Precompiled Ruby installs now *auto-select* the `.no_yjit` release asset on Linux when detected glibc is older than 2.35, with fallback to the standard precompiled build if the variant isn’t available. > > This adds a process-wide glibc version detector (`LINUX_GLIBC_VERSION` via `ldd --version`) and updates the Ruby plugin’s GitHub release asset selection and download filename handling to support the no-YJIT artifact naming. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 8804fe6. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Output tarballs (backwards compatible — no existing names change):
ruby-X.Y.Z.x86_64_linux.tar.gz— YJIT (unchanged)ruby-X.Y.Z.no_yjit.x86_64_linux.tar.gz— no YJIT (new, additive)Tested no-YJIT x86_64 binary on Amazon Linux 2 Docker (glibc 2.26) — Ruby, zlib, yaml, openssl, and HTTPS all work. Max glibc symbol in binary: 2.14.
Test plan
.no_yjit.naming convention🤖 Generated with Claude Code