chore(ci): stop release-plz from saving build cache#9297
Merged
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Contributor
Greptile SummaryThis PR adds Confidence Score: 5/5Safe to merge — single-line CI config change with no risk to production. The change is a correct, well-scoped use of the No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant GHA as GitHub Actions
participant Cache as GitHub Actions Cache
participant Job as release-plz job
GHA->>Job: Trigger (push to main / schedule)
Job->>Cache: Restore rust build cache (shared-key: build)
Cache-->>Job: Cache hit (restored)
Job->>Job: cargo build --all-features
Note over Job,Cache: save-if: false — no cache write
Job->>Job: mise run release-plz
Reviews (1): Last reviewed commit: "chore(ci): stop release-plz from saving ..." | Re-trigger Greptile |
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.18 x -- echo |
21.5 ± 0.4 | 20.7 | 23.8 | 1.00 |
mise x -- echo |
21.6 ± 0.5 | 20.9 | 26.6 | 1.01 ± 0.03 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.18 env |
21.0 ± 0.7 | 20.2 | 29.3 | 1.00 |
mise env |
21.4 ± 0.7 | 20.3 | 23.9 | 1.02 ± 0.05 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.18 hook-env |
22.3 ± 0.6 | 21.0 | 27.7 | 1.00 ± 0.04 |
mise hook-env |
22.3 ± 0.7 | 21.3 | 24.4 | 1.00 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.18 ls |
19.2 ± 0.4 | 18.2 | 21.6 | 1.00 |
mise ls |
19.5 ± 0.5 | 18.5 | 21.4 | 1.01 ± 0.03 |
xtasks/test/perf
| Command | mise-2026.4.18 | mise | Variance |
|---|---|---|---|
| install (cached) | 146ms | 148ms | -1% |
| ls (cached) | 76ms | 75ms | +1% |
| bin-paths (cached) | 80ms | 79ms | +1% |
| task-ls (cached) | 803ms | 804ms | +0% |
1 task
jdx
added a commit
that referenced
this pull request
Apr 22, 2026
## Summary - Re-enable `lint` as the Linux writer of the shared `build` rust-cache entry on `main` (revert the save-side of #9298) - Picks up pre-existing prettier drift in two docs files flagged by the pre-commit hook ## Why After #9297 (release-plz save-if: false) and #9298 (lint save-if: false), no Ubuntu job remained that saved the shared `build` cache. The other jobs with `shared-key: build` that still save (`unit` on macOS, `windows-unit`) use different per-OS cache entries, so the Linux `build` entry had no writer at all. It would stay stuck at whatever was saved before #9298 and eventually be evicted (7-day LRU / 10GB cap) with nothing to refresh it — which is why the most recent `release-plz` run didn't restore a fresh cache. `lint` is a good writer choice: it runs the most thorough build (`cargo clippy --all-features --all-targets` plus `cargo deny`/`msrv`/`machete`), producing the most complete `target/` for downstream restorers. ## Test plan - [ ] Next `main` push: verify lint job saves the `build` cache and subsequent PRs restore it *This PR was generated by an AI coding assistant.* <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: only adjusts CI cache save conditions and tweaks markdown formatting in docs, with no production code or runtime behavior changes. > > **Overview** > Re-enables saving the shared `rust-cache` `build` entry from the Ubuntu `lint` job by changing `save-if` to only write on `refs/heads/main`, ensuring Linux builds keep the cache refreshed. > > Also fixes markdown admonition formatting in two docs pages (`backend-plugin-development.md`, `url-replacements.md`) to match the expected warning callout style. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit acfdeaf. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-plzrestoring the shared Rustbuildcacherelease-plzfrom writing that cache back to GitHub ActionsWhy
release-plzrefresh the oversized shared Linux Rust cache onmainTesting
This PR was generated by an AI coding assistant.
Note
Low Risk
Workflow-only change that tweaks GitHub Actions caching behavior; low functional risk aside from potentially affecting build speed/cache freshness.
Overview
The
release-plzGitHub Actions workflow now configuresSwatinem/rust-cachewithsave-if: false, so it will restore the sharedbuildcache but won’t save/update that cache after the run.Reviewed by Cursor Bugbot for commit b841ab2. Bugbot is set up for automated code reviews on this repo. Configure here.