chore(deps): unblock cargo-deny advisories check#9112
Conversation
- Drop stale ignore for RUSTSEC-2026-0066 (astral-tokio-tar): crate is no longer in the dep tree, so cargo-deny was failing on the unused ignore with `advisory-not-detected`. - Update rustls-webpki 0.103.11 -> 0.103.12 to pick up the fix for RUSTSEC-2026-0098 / RUSTSEC-2026-0099 on that line. - Ignore RUSTSEC-2026-0098 / RUSTSEC-2026-0099 for the transitive rustls-webpki 0.101.7 pulled in by aws-smithy-http-client via rustls 0.21 — no upgrade path until aws-sdk bumps rustls. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Routine lockfile refresh pulled alongside the deny.toml cleanup. Bumps rustls 0.23.37→0.23.38, tokio 1.51.1→1.52.0, hyper-rustls 0.27.7→0.27.9, rattler 0.40.5→0.40.6 and friends, plus assorted minor/patch updates. aws-sdk / aws-config / aws-smithy are left alone — moving off the legacy `rustls` feature to a newer stack would require an MSRV bump. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Greptile SummaryUnblocks Confidence Score: 5/5Safe to merge — deny.toml changes are correct, all remaining concerns are P2 documentation clarifications. The code changes are correct: removing the stale advisory ignore and adding well-reasoned ignores for the two TLS advisories that cannot be resolved without an MSRV bump. The only finding is a P2 clarification that the astral-tokio-tar crate is still in the dep tree (upgraded to a patched version), not removed entirely as the PR description implies. No logic bugs, security issues, or blocking concerns. No files require special attention. The deny.toml changes are correct; the P2 note is informational only. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[mise / aws-sdk-s3] --> B[aws-smithy-http-client 1.1.9]
B --> C[rustls 0.21.12\nlegacy path]
B --> D[rustls 0.23.38\nmodern path]
C --> E[rustls-webpki 0.101.7\n⚠️ RUSTSEC-2026-0098\n⚠️ RUSTSEC-2026-0099\nignored — awaiting aws-sdk MSRV bump]
D --> F[rustls-webpki 0.103.12\n✅ patched in this PR]
G[rattler_package_streaming] --> H[astral-tokio-tar 0.6.0\n✅ upgraded from 0.5.6\nRUSTSEC-2026-0066 ignore removed]
Reviews (3): Last reviewed commit: "chore(deps): bump sigstore-verification ..." | Re-trigger Greptile |
There was a problem hiding this comment.
Code Review
This pull request involves several dependency downgrades in Cargo.lock, including windows-sys, itertools, and base64, alongside an upgrade for rustls-webpki. It also updates deny.toml to ignore security advisories RUSTSEC-2026-0098 and RUSTSEC-2026-0099. Feedback suggests that instead of ignoring these vulnerabilities, the project should update aws-sdk-s3 to a version that utilizes rustls 0.23, as the current MSRV (1.88) is sufficient to support the fix.
| { id = "RUSTSEC-2026-0098", reason = "rustls-webpki 0.101.7 URI name constraints - transitive via aws-smithy-http-client/rustls 0.21, no safe upgrade until aws-sdk bumps rustls" }, | ||
| { id = "RUSTSEC-2026-0099", reason = "rustls-webpki 0.101.7 wildcard name constraints - transitive via aws-smithy-http-client/rustls 0.21, no safe upgrade until aws-sdk bumps rustls" }, |
There was a problem hiding this comment.
The provided reason for ignoring these advisories states an MSRV bump is required to switch to default-https-client. The project's MSRV is 1.88, which appears to be sufficient for recent aws-sdk versions that use rustls 0.23 via the default-https-client feature (which requires Rust 1.75).
To avoid ignoring these security advisories, consider updating aws-sdk-s3 and switching to the default-https-client feature in Cargo.toml. This would resolve the underlying issue rather than suppressing the warnings.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.12 x -- echo |
24.0 ± 0.4 | 23.2 | 26.9 | 1.00 |
mise x -- echo |
24.6 ± 0.4 | 23.9 | 26.9 | 1.02 ± 0.02 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.12 env |
23.8 ± 0.8 | 22.8 | 34.1 | 1.00 |
mise env |
24.1 ± 0.7 | 23.2 | 32.9 | 1.02 ± 0.05 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.12 hook-env |
24.2 ± 0.3 | 23.4 | 25.5 | 1.00 |
mise hook-env |
24.7 ± 0.6 | 23.8 | 32.3 | 1.02 ± 0.03 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.12 ls |
21.7 ± 0.8 | 20.6 | 35.9 | 1.00 |
mise ls |
21.8 ± 0.4 | 21.0 | 23.7 | 1.01 ± 0.04 |
xtasks/test/perf
| Command | mise-2026.4.12 | mise | Variance |
|---|---|---|---|
| install (cached) | 155ms | 154ms | +0% |
| ls (cached) | 81ms | 79ms | +2% |
| bin-paths (cached) | 85ms | 85ms | +0% |
| task-ls (cached) | 777ms | 774ms | +0% |
### 🐛 Bug Fixes - **(go)** honor install_before for module versions by @mariusvniekerk in [#9097](#9097) - **(vfox-plugin)** support Git URL with commit hash for mise.toml by @Oyami-Srk in [#9099](#9099) - `MISE_FETCH_REMOTE_VERSIONS_CACHE` not respected by @mcncl in [#9096](#9096) ### 📦️ Dependency Updates - unblock cargo-deny advisories check by @jdx in [#9112](#9112) ### New Contributors - @mariusvniekerk made their first contribution in [#9097](#9097) - @mcncl made their first contribution in [#9096](#9096) - @Oyami-Srk made their first contribution in [#9099](#9099)
### 🐛 Bug Fixes - **(go)** honor install_before for module versions by @mariusvniekerk in [#9097](#9097) - **(schema)** support os arch filters by @risu729 in [#9095](#9095) - **(vfox-plugin)** support Git URL with commit hash for mise.toml by @Oyami-Srk in [#9099](#9099) - `MISE_FETCH_REMOTE_VERSIONS_CACHE` not respected by @mcncl in [#9096](#9096) ### 📦️ Dependency Updates - unblock cargo-deny advisories check by @jdx in [#9112](#9112) ### New Contributors - @mariusvniekerk made their first contribution in [#9097](#9097) - @mcncl made their first contribution in [#9096](#9096) - @Oyami-Srk made their first contribution in [#9099](#9099)
## [2026.4.14](https://github.com/jdx/mise/compare/v2026.4.13..v2026.4.14) - 2026-04-15 ### Chore - bump sigstore-verification by @jdx in [#9128](jdx/mise#9128) ## [2026.4.13](https://github.com/jdx/mise/compare/v2026.4.12..v2026.4.13) - 2026-04-15 ### 🐛 Bug Fixes - **(go)** honor install_before for module versions by @mariusvniekerk in [#9097](jdx/mise#9097) - **(vfox-plugin)** support Git URL with commit hash for mise.toml by @Oyami-Srk in [#9099](jdx/mise#9099) - `MISE_FETCH_REMOTE_VERSIONS_CACHE` not respected by @mcncl in [#9096](jdx/mise#9096) ### 📦️ Dependency Updates - unblock cargo-deny advisories check by @jdx in [#9112](jdx/mise#9112) ### New Contributors - @mariusvniekerk made their first contribution in [#9097](jdx/mise#9097) - @mcncl made their first contribution in [#9096](jdx/mise#9096) - @Oyami-Srk made their first contribution in [#9099](jdx/mise#9099) ## [2026.4.12](https://github.com/jdx/mise/compare/v2026.4.11..v2026.4.12) - 2026-04-15 ### 🚀 Features - **(npm)** use --min-release-age for npm 11.10.0+ supply chain protection by @webkaz in [#9072](jdx/mise#9072) - **(registry)** add openfga by @mnm364 in [#9084](jdx/mise#9084) - **(task)** allow to set confirmation default by @roele in [#9089](jdx/mise#9089) - support os/arch compound syntax in tool os filtering by @RobertDeRose in [#9088](jdx/mise#9088) ### 🐛 Bug Fixes - **(activate)** export __MISE_EXE and resolve bare ARGV0 to absolute path by @fru1tworld in [#9081](jdx/mise#9081) - **(install)** support aliased installs sharing a backend by @jdx in [#9093](jdx/mise#9093) - **(shim)** use which_no_shims when resolving mise binary in reshim and doctor by @kevinswiber in [#9071](jdx/mise#9071) - filter empty segments in colon-separated env var parsing by @baby-joel in [#9076](jdx/mise#9076) ### 📚 Documentation - fix wrong file reference to forgejo backend implemenation by @roele in [#9090](jdx/mise#9090) - fix cli token command for token resolution by @roele in [#9077](jdx/mise#9077)
Summary
RUSTSEC-2026-0066(astral-tokio-tar) — the crate is no longer in the dep tree, so cargo-deny was failing withadvisory-not-detectedand blocking every PR's lint job (e.g. registry: add sheldon #9104).rustls-webpki0.103.11 → 0.103.12 viacargo updateto pick up the fix forRUSTSEC-2026-0098/RUSTSEC-2026-0099on the modern rustls 0.23 line.RUSTSEC-2026-0098/RUSTSEC-2026-0099for the transitiverustls-webpki 0.101.7pulled in byaws-smithy-http-clientviarustls 0.21. Swapping the aws-config / aws-sdk-s3rustlsfeature todefault-https-clientwould move to hyper 1.x / rustls 0.23 but requires an MSRV bump, so we wait on aws-sdk to backport or until we bump MSRV.Verified locally with `cargo deny check advisories` → `advisories ok`.
Test plan
🤖 Generated with Claude Code
Note
Medium Risk
Primarily dependency/lockfile churn, including updates in TLS/crypto and async networking crates (
rustls,hyper-rustls,tokio), which can affect runtime behavior despite being mostly patch-level bumps.Overview
Unblocks
cargo-denyadvisory checks by updating the advisory ignore list: removes the stale ignore forRUSTSEC-2026-0066and adds ignores forRUSTSEC-2026-0098/RUSTSEC-2026-0099affecting transitiverustls-webpki 0.101.7(via therustls 0.21AWS dependency chain).Refreshes
Cargo.lockviacargo update, notably bumping the modern TLS stack (hyper-rustlsandrustls/rustls-webpkion the 0.23 line) and rolling forward various supporting deps (e.g.,tokio,rand,openssl,rayon), plus consolidating/removing an extrawindows-registryversion entry.Reviewed by Cursor Bugbot for commit a7e0c08. Bugbot is set up for automated code reviews on this repo. Configure here.