Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the mise test-tool's behavior by ensuring all command output, including errors, is captured and processed uniformly. It also streamlines the testing configurations across various tools in the registry by eliminating previously necessary output redirection and formatting workarounds, leading to cleaner and more robust test definitions.

Highlights

• mise test-tool improvements: The mise test-tool now redirects stderr to stdout for comprehensive output capture and automatically strips ANSI escape codes before comparing test results, enhancing test reliability.
• Registry test simplification: Redundant 2>&1 redirects and manual ANSI stripping commands have been removed from numerous registry/*.toml test configurations, simplifying test definitions.

Greptile Summary

This PR fixes the ni test (and hardens all other registry tool tests) by centralising two behaviours inside mise test-tool: stderr is now redirected to stdout at the Rust level (stderr_to_stdout()), and ANSI escape codes are stripped from the captured output before comparing against the expected string. As a result, all per-tool workarounds — the 2>&1 shell redirects in 27 registry .toml files, the manual sed ANSI stripping in btop.toml, and the hardcoded ANSI sequences in ni.toml's expected string — are cleanly removed.

Key changes:

• src/cli/test_tool.rs: adds stderr_to_stdout() to the command builder and uses console::strip_ansi_codes before matching; error messages now show the cleaned output (addressing a prior review comment).
• 27 registry files: mechanical removal of 2>&1 and/or ANSI workarounds.
• registry/ni.toml: hardcoded escape sequences removed from the expected value.
• registry/imagemagick.toml: test was commented out (not merely updated) — unlike every other file in the PR; the reason is not documented.

Confidence Score: 4/5

• PR is safe to merge; the imagemagick skip and raw ANSI print are minor follow-up items.
• The core logic change is correct and minimal — two lines in test_tool.rs. All registry cleanups are mechanical. The previously raised concern about raw ANSI in the error message has been fixed. Two small non-blocking P2s remain: (1) miseprintln! still emits raw ANSI to non-TTY outputs, and (2) the imagemagick test was silently commented out without explanation.
• registry/imagemagick.toml — test was commented out entirely rather than updated; reason is undocumented.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[mise test-tool <tool>] --> B[Install tool]
    B --> C[Build command]
    C --> D["Run: sh -c <cmd>\nstderr_to_stdout + stdout_capture"]
    D --> E{Exit code?}
    E -- "0" --> F[Capture combined stdout+stderr]
    E -- "127 (not found)" --> G[Log bin dirs & output]
    E -- "other" --> H[Return error]
    G --> H
    F --> I["miseprintln! raw stdout (ANSI preserved for TTY)"]
    I --> J["strip_ansi_codes(stdout) → clean_stdout"]
    J --> K{clean_stdout contains expected?}
    K -- "yes" --> L[OK ✅]
    K -- "no" --> M["Error: expected X, got clean_stdout"]

_{Reviews (4): Last reviewed commit: "registry: disable imagemagick version te..." | Re-trigger Greptile}