Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the mise tool's ability to efficiently retrieve the latest stable release for GitHub and Forgejo repositories. By integrating direct API calls to their /releases/latest endpoints, the system now bypasses the need to fetch and process potentially large lists of releases, leading to faster and more resource-friendly operations. This change primarily benefits users interacting with repositories that frequently publish pre-releases, ensuring that the latest stable version is identified quickly and accurately.

Highlights

• Optimized Latest Release Fetching: Implemented a new latest_stable_version method within the UnifiedGitBackend to leverage dedicated /releases/latest API endpoints for GitHub and Forgejo. This significantly improves performance by avoiding the need to paginate through all releases, especially for repositories with numerous pre-releases.
• Dedicated API Endpoints: Added specific get_release_latest functions for both GitHub and Forgejo APIs, which directly query their respective /releases/latest endpoints. These functions include caching mechanisms to further reduce redundant API calls.
• GitLab Handling: Explicitly noted that GitLab does not offer a similar /releases/latest endpoint, so the existing method for fetching the latest version will continue to be used for GitLab repositories.
• End-to-End Testing: Introduced a new assert_not_empty helper function in e2e/assert.sh and added a corresponding end-to-end test case in e2e/backend/test_github to verify the correct functionality of fetching the latest GitHub release using the new optimized approach.

@jdx Looks like there is an upstream issue with e2e/backend/test_aqua_github_attestations and the latest version of aqua:goreleaser/goreleaser. How come latest version is 2.14.2 if this is not merged yet (aquaproj/aqua-registry#49986)?

  ✖ mise use aqua:goreleaser/goreleaser@2.14.1
mise Cannot parse Rekor public key with id cf1199155bddd051268d1f16ac5c0c75c009f6fb5a63f4177f8e18d7051e3fa0: Pkcs8 spki error : Ecdsa-P256 from der bytes to public key failed: unknown/unsupported algorithm OID: 1.2.840.10045.2.1
aqua:goreleaser/goreleaser@2.14.1 extract goreleaser_Darwin_all.tar.gz                                                                     ✔
mise ~/Downloads/mise/mise.toml tools: aqua:goreleaser/goreleaser@2.14.1

  ❯ mise use aqua:goreleaser/goreleaser@2.14.2
aqua:goreleaser/goreleaser@2.14.2 verify GitHub artifact attestations                                                                      ◡
mise ERROR Failed to install aqua:goreleaser/goreleaser@2.14.2: No GitHub artifact attestations found for aqua:goreleaser/goreleaser@2.14.2, but they are expected per aqua registry configuration
mise ERROR Run with --verbose or MISE_VERBOSE=1 for more information

we don't use the versions in aqua-registry at all

aqua even doesn't use the PR to update the latest versions. Those PRs just notifies shunsuke the incompatibility of aqua registry for the latest version.
pkg.yml files are purely for testing.

Greptile Summary

This PR optimizes mise latest for GitHub and Forgejo backends by using the /releases/latest API endpoint instead of fetching all paginated releases — a significant improvement for repositories with many pre-releases. A new latest_stable_version override is added to UnifiedGitBackend that hits the fast endpoint and falls back to the paginated path only when needed (e.g. when the globally-latest release doesn't match a configured version_prefix, or when the endpoint returns an error). GitLab, which lacks an equivalent endpoint, is short-circuited back to the existing paginated behavior.

Key changes:

• src/backend/github.rs: New latest_stable_version implementation routes GitHub and Forgejo repos to the /releases/latest endpoint, filters by version_prefix, and falls back to the paginated path when necessary.
• src/forgejo.rs: Fixes get_release_ to correctly call GET /repos/{repo}/releases/latest when tag == "latest", rather than the incorrect /releases/tags/latest that would always 404.
• e2e/assert.sh: Adds the assert_not_empty test helper, consistently modeled on the existing assert_empty.
• e2e/backend/test_github: Adds a smoke test for the new fast path. The test uses an external third-party repository (unikraft/kraftkit) which could become a flaky CI dependency if that project changes its release cadence or repo structure.

Confidence Score: 4/5

• Safe to merge with the test reliability concern noted; the core logic is correct and well-guarded by version_prefix filtering and fallback.
• The primary logic change (using /releases/latest endpoint) is correct for both GitHub and Forgejo, with proper filtering and a safe fallback. The Forgejo endpoint fix is accurate. The only concern is the e2e test anchoring to an external repo, which is a reliability risk for CI rather than a correctness issue.
• The e2e/backend/test_github test should be updated to use a controlled repository to prevent future CI flakiness.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["latest_stable_version(config)"] --> B{offline mode?}
    B -- yes --> C["return Ok(None)"]
    B -- no --> D{backend type?}
    D -- GitLab --> E["return latest_version(config, 'latest')"]
    D -- Forgejo --> F["forgejo::get_release_for_url(api_url, repo, 'latest')"]
    D -- GitHub --> G["github::get_release_for_url(api_url, repo, 'latest')"]
    F --> H{HTTP GET /releases/latest}
    G --> H
    H -- OK --> I["tag_name from response"]
    H -- Err --> J["debug log, None"]
    I --> K{version_prefix match?}
    J --> K
    K -- matches / no prefix --> L["strip_version_prefix → return Ok(Some(version))"]
    K -- no match --> M["fallback: latest_version(config, 'latest')"]
    M --> N["paginated list_remote_versions"]

_{Last reviewed commit: bff5c4a}

A few things I noticed:

1. version_prefix not respected — latest_stable_version doesn't filter by version_prefix from opts before accepting the /releases/latest result. If a user has version_prefix = "v1" and the repo's latest release is v2.0.0, this will return the wrong version. list_version_info already does this filtering — the new method should too, falling back to the existing path when the prefix doesn't match.

2. Redundant with existing code — get_release_ in src/github.rs already special-cases tag == "latest" to hit /releases/latest with the same cache key. The new get_release_latest functions duplicate that. Could just call get_release_for_url(api_url, repo, "latest") instead.

3. Errors silently swallowed — .ok() discards all API errors including rate limits, then falls back to the more expensive paginated path which could make rate limiting worse. Would be better to at least log a warning, or only fall back on 404s.

4. No offline mode check — Other remote-version code paths short-circuit on Settings::get().offline(), but this doesn't.

This comment was generated by Claude Code.

The Forgejo path in get_release_latest won't actually hit the right endpoint. It calls get_release_for_url(api_url, repo, "latest") which goes through get_release_ in src/forgejo.rs:

async fn get_release_(api_url: &str, repo: &str, tag: &str) -> Result<ForgejoRelease> {
    let url = format!("{api_url}/repos/{repo}/releases/tags/{tag}");

This constructs /repos/{repo}/releases/tags/latest (looking for a tag literally named "latest") instead of /repos/{repo}/releases/latest. The GitHub side works because get_release_ in src/github.rs has a tag == "latest" special case, but the Forgejo side doesn't.

I confirmed that Forgejo does support /repos/{owner}/{repo}/releases/latest (tested against Codeberg's API). The fix would be to add the same special case to forgejo::get_release_:

async fn get_release_(api_url: &str, repo: &str, tag: &str) -> Result<ForgejoRelease> {
    let url = if tag == "latest" {
        format!("{api_url}/repos/{repo}/releases/latest")
    } else {
        format!("{api_url}/repos/{repo}/releases/tags/{tag}")
    };

Without this, the Forgejo optimization silently 404s and falls back to the paginated path every time.

This comment was generated by Claude Code.