Skip to content

feat: add github_content package support for aqua backend#8147

Merged
jdx merged 5 commits intojdx:mainfrom
risu729:github-content-path
Feb 15, 2026
Merged

feat: add github_content package support for aqua backend#8147
jdx merged 5 commits intojdx:mainfrom
risu729:github-content-path

Conversation

@risu729
Copy link
Contributor

@risu729 risu729 commented Feb 14, 2026

This PR adds support for github_content packages in the Aqua backend, enabling tools like semver (fsaintjacques/semver-tool) to be installed via mise. It also enforces the path field for such packages.
Fixes #5833

Copilot AI review requested due to automatic review settings February 14, 2026 09:52
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @risu729, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Aqua backend by introducing robust support for github_content packages. This change allows mise to directly fetch and install individual files from GitHub repositories, which is particularly useful for tools distributed as single scripts. It also ensures that such packages explicitly define the file path, improving clarity and preventing ambiguity during installation.

Highlights

  • Aqua Backend github_content Support: Added support for github_content package type within the Aqua backend, allowing direct installation of single files from GitHub repositories.
  • Path Field Enforcement: The path field is now mandatory for github_content packages, ensuring that a specific file within the repository is targeted for installation.
  • Semver Tool Integration: The fsaintjacques/semver-tool is now enabled for installation via the Aqua backend, leveraging the new github_content functionality.
Changelog
  • registry/semver.toml
    • Uncommented and enabled the Aqua backend entry for fsaintjacques/semver-tool.
  • src/backend/aqua.rs
    • Modified the AquaPackageType::GithubContent handling to require a path field, returning an error if not provided.
    • Introduced a new github_content_url function to construct URLs for raw GitHub content.
    • Separated AquaPackageType::GithubArchive and AquaPackageType::GithubContent logic for URL generation.
    • Updated the installation process for AquaPackageType::GithubContent to directly copy the file and make it executable when a path is specified, rather than attempting to untar.
Activity
  • No specific activity (comments, reviews, etc.) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR adds support for github_content packages in the Aqua backend, which is a great feature. The changes look mostly good, with separate handling for GithubContent in get_url and install. I've left a couple of suggestions for improvement regarding code clarity and removing dead code.

Additionally, I noticed that resolve_lock_info function, which is responsible for cross-platform lockfile generation, seems to be missing specific handling for GithubContent. It currently treats it the same as GithubArchive, which might lead to incorrect behavior. While this is outside the scope of the current diff, it would be good to address this in a follow-up PR to ensure github_content packages are fully supported.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for github_content package types in the Aqua backend, enabling tools that distribute single executable files (like semver-tool) to be installed via mise. The implementation introduces a new URL construction method for GitHub raw content and modifies both the download URL generation and installation logic to handle these packages.

Changes:

  • Added github_content_url method to construct raw.githubusercontent.com URLs for single-file packages
  • Split GithubContent handling from GithubArchive in get_url method with path validation
  • Updated installation logic to copy raw files directly instead of attempting extraction
  • Enabled aqua:fsaintjacques/semver-tool backend in the semver registry

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/backend/aqua.rs Added github_content_url method and split GithubContent/GithubArchive handling with path validation and direct file copy for single-file packages
registry/semver.toml Enabled aqua backend for semver-tool now that github_content packages are supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jdx jdx merged commit 0f1634d into jdx:main Feb 15, 2026
33 checks passed
@risu729 risu729 deleted the github-content-path branch February 15, 2026 13:55
mise-en-dev added a commit that referenced this pull request Feb 16, 2026
### 🚀 Features

- **(vfox)** allow plugins to request env var redaction via
MiseEnvResult by @jdx in [#8166](#8166)
- add a default_host setting for rust by @aacebedo in
[#8154](#8154)
- add github_content package support for aqua backend by @risu729 in
[#8147](#8147)
- support devEngines.runtime in deno by @risu729 in
[#8144](#8144)

### 🐛 Bug Fixes

- **(asset_matcher)** penalize vsix files by @risu729 in
[#8151](#8151)
- **(edit)** strip formatting whitespace from TOML values in `mise edit`
by @jdx in [#8162](#8162)
- **(install)** improve --locked support for python and ubi backends by
@jdx in [#8163](#8163)
- **(npm)** suppress npm update notifier while npm install by @risu729
in [#8152](#8152)
- **(schema)** add task_templates, extends, and timeout by @risu729 in
[#8145](#8145)

### 🚜 Refactor

- **(registry)** remove [key=value] options syntax from backends by
@risu729 in [#8146](#8146)

### 📚 Documentation

- **(settings)** remove wrong tip for github_attestations by @risu729 in
[#8158](#8158)

### Chore

- **(release-plz)** delete embedded plugins directory before update by
@risu729 in [#8149](#8149)
- adds necessary env var to the mcp help message in cli by @joaommartins
in [#8133](#8133)

### New Contributors

- @joaommartins made their first contribution in
[#8133](#8133)

## 📦 Aqua Registry Updates

#### New Packages (5)

- [`containers/podlet`](https://github.com/containers/podlet)
-
[`hickford/git-credential-azure`](https://github.com/hickford/git-credential-azure)
-
[`hickford/git-credential-oauth`](https://github.com/hickford/git-credential-oauth)
- [`kovetskiy/mark`](https://github.com/kovetskiy/mark)
- [`openbao/openbao/bao`](https://github.com/openbao/openbao/bao)
lucasew pushed a commit to lucasew/CONTRIB-mise that referenced this pull request Feb 18, 2026
This PR adds support for `github_content` packages in the Aqua backend,
enabling tools like `semver` (fsaintjacques/semver-tool) to be installed
via `mise`. It also enforces the `path` field for such packages.
Fixes jdx#5833

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
lucasew pushed a commit to lucasew/CONTRIB-mise that referenced this pull request Feb 18, 2026
### 🚀 Features

- **(vfox)** allow plugins to request env var redaction via
MiseEnvResult by @jdx in [jdx#8166](jdx#8166)
- add a default_host setting for rust by @aacebedo in
[jdx#8154](jdx#8154)
- add github_content package support for aqua backend by @risu729 in
[jdx#8147](jdx#8147)
- support devEngines.runtime in deno by @risu729 in
[jdx#8144](jdx#8144)

### 🐛 Bug Fixes

- **(asset_matcher)** penalize vsix files by @risu729 in
[jdx#8151](jdx#8151)
- **(edit)** strip formatting whitespace from TOML values in `mise edit`
by @jdx in [jdx#8162](jdx#8162)
- **(install)** improve --locked support for python and ubi backends by
@jdx in [jdx#8163](jdx#8163)
- **(npm)** suppress npm update notifier while npm install by @risu729
in [jdx#8152](jdx#8152)
- **(schema)** add task_templates, extends, and timeout by @risu729 in
[jdx#8145](jdx#8145)

### 🚜 Refactor

- **(registry)** remove [key=value] options syntax from backends by
@risu729 in [jdx#8146](jdx#8146)

### 📚 Documentation

- **(settings)** remove wrong tip for github_attestations by @risu729 in
[jdx#8158](jdx#8158)

### Chore

- **(release-plz)** delete embedded plugins directory before update by
@risu729 in [jdx#8149](jdx#8149)
- adds necessary env var to the mcp help message in cli by @joaommartins
in [jdx#8133](jdx#8133)

### New Contributors

- @joaommartins made their first contribution in
[jdx#8133](jdx#8133)

## 📦 Aqua Registry Updates

#### New Packages (5)

- [`containers/podlet`](https://github.com/containers/podlet)
-
[`hickford/git-credential-azure`](https://github.com/hickford/git-credential-azure)
-
[`hickford/git-credential-oauth`](https://github.com/hickford/git-credential-oauth)
- [`kovetskiy/mark`](https://github.com/kovetskiy/mark)
- [`openbao/openbao/bao`](https://github.com/openbao/openbao/bao)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants