Conversation
Summary of ChangesHello @runkids, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds the skillshare tool to the mise registry. The configuration is mostly correct, but I've identified a likely error in the test configuration. Based on the skillshare tool's implementation using the cobra library, the version command's output will be skillshare version ..., not skillshare v.... I've provided a suggestion to correct the expected value in the test to prevent it from failing. With this change, the new registry entry should work as intended.
| @@ -0,0 +1,3 @@ | |||
| backends = ["github:runkids/skillshare"] | |||
| description = "Sync AI CLI skills from a single source to Claude Code, Cursor, Gemini CLI, and 40+ tools" | |||
| test = { cmd = "skillshare -v", expected = "skillshare v{{version}}" } | |||
There was a problem hiding this comment.
The output of skillshare -v is likely skillshare version {{version}} rather than skillshare v{{version}}. The cobra library, which skillshare uses, defaults to printing 'version' in the version output. This change will align the test with the expected output and ensure it passes.
| test = { cmd = "skillshare -v", expected = "skillshare v{{version}}" } | |
| test = { cmd = "skillshare -v", expected = "skillshare version {{version}}" } |
da536e9 to
754cb44
Compare
|
The |
754cb44 to
cdea305
Compare
|
Found a conflict between
All existing registry entries use inline table format ( |
## Summary
- The `validate-new-tools` CI job used `grep -q '^test = \['` to check
for test fields, but all 510 registry tools use inline table syntax
(`test = { ... }`), not array syntax (`test = [...]`)
- Changed the pattern to `^test = ` to match both formats
- This was blocking PR #8095 (and would block any new registry tool PR
from non-maintainers)
## Test plan
- [x] Verified all 510 existing registry tools use `test = {` syntax
- [x] Verified 0 tools use `test = [` syntax
- [x] Lint checks pass
🤖 Generated with [Claude Code](https://claude.com/claude-code)
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Low Risk**
> Single-line change to a CI grep pattern; low risk aside from
potentially allowing malformed `test` lines to slip through if they
start with `test = `.
>
> **Overview**
> Fixes the `validate-new-tools` CI check in `registry.yml` to accept
any `test = ...` field in new `registry/*.toml` tool definitions
(instead of only matching the array form `test = [`), preventing false
failures when tools use non-array test syntax.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
6fde3ce. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
## Summary
- The `validate-new-tools` CI job used `grep -q '^test = \['` to check
for test fields, but all 510 registry tools use inline table syntax
(`test = { ... }`), not array syntax (`test = [...]`)
- Changed the pattern to `^test = ` to match both formats
- This was blocking PR jdx#8095 (and would block any new registry tool PR
from non-maintainers)
## Test plan
- [x] Verified all 510 existing registry tools use `test = {` syntax
- [x] Verified 0 tools use `test = [` syntax
- [x] Lint checks pass
🤖 Generated with [Claude Code](https://claude.com/claude-code)
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Low Risk**
> Single-line change to a CI grep pattern; low risk aside from
potentially allowing malformed `test` lines to slip through if they
start with `test = `.
>
> **Overview**
> Fixes the `validate-new-tools` CI check in `registry.yml` to accept
any `test = ...` field in new `registry/*.toml` tool definitions
(instead of only matching the array form `test = [`), preventing false
failures when tools use non-array test syntax.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
6fde3ce. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Summary
Registry entry
Test plan
mise install skillshareinstalls the binary from GitHub releasesskillshare -voutputsskillshare v<version>matching the expected format