Conversation
Summary of ChangesHello @zdunecki, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates Orval into the project's registry, providing a mechanism to automatically generate type-safe API clients from OpenAPI specifications. This addition aims to improve developer experience by automating client code creation, ensuring type safety, and reducing manual effort in API consumption. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull request overview
Adds an Orval registry entry so the tool can be installed via npm and described/tested from the registry.
Changes:
- Introduces
registry/orval.tomlwith npm backend configuration - Adds a human-readable description for Orval
- Adds a basic CLI test command/version check
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,3 @@ | |||
| backends = ["npm:orval"] | |||
| description = "Generate type-safe TypeScript clients from OpenAPI specifications provided by https://orval.dev" | |||
| test = ["orval --version", "{{version}}"] | |||
There was a problem hiding this comment.
This test entry appears to mix a command (orval --version) with a standalone template token ({{version}}). If the registry runner executes each array element as a separate command, {{version}} will be executed on its own and fail. Consider aligning this with the registry’s established test schema (e.g., either a single command string, or an explicit command + expected output pattern if supported).
| test = ["orval --version", "{{version}}"] | |
| test = ["orval", "--version"] |
There was a problem hiding this comment.
Code Review
This pull request adds support for orval, a tool for generating type-safe API clients from OpenAPI specifications. The change is straightforward, adding a new registry file that defines orval as an npm package and includes a test command. My feedback includes a minor suggestion to improve the conciseness of the tool's description for better consistency and user experience in the CLI.
| @@ -0,0 +1,3 @@ | |||
| backends = ["npm:orval"] | |||
| description = "Generate type-safe TypeScript clients from OpenAPI specifications provided by https://orval.dev" | |||
There was a problem hiding this comment.
For consistency and to ensure a clean display in command-line interfaces, it's best to keep descriptions concise and focused on the tool's functionality. Including URLs can clutter the output. The project's website is already available in the pull request for reference.
| description = "Generate type-safe TypeScript clients from OpenAPI specifications provided by https://orval.dev" | |
| description = "Generate type-safe TypeScript clients from OpenAPI specifications" |
### 🚀 Features - **(shim)** add native .exe shim mode for Windows by @jdx in [#8045](#8045) ### 🐛 Bug Fixes - **(install)** preserve config options and registry defaults by @jdx in [#8044](#8044) - **(link)** linked versions override lockfile during resolution by @jdx in [#8050](#8050) - **(release)** preserve aqua-registry sections in changelog across releases by @jdx in [#8047](#8047) - ls --all-sources shows duplicate entries by @roele in [#8042](#8042) ### 📚 Documentation - replace "inherit" terminology with config layering by @jdx in [#8046](#8046) ### 📦 Registry - switch oxlint to npm backend by default by @risu729 in [#8038](#8038) - add orval (npm:orval) by @zdunecki in [#8051](#8051) ### New Contributors - @zdunecki made their first contribution in [#8051](#8051)
[Orval](https://orval.dev/) - Generate type-safe API clients from OpenAPI.
### 🚀 Features - **(shim)** add native .exe shim mode for Windows by @jdx in [jdx#8045](jdx#8045) ### 🐛 Bug Fixes - **(install)** preserve config options and registry defaults by @jdx in [jdx#8044](jdx#8044) - **(link)** linked versions override lockfile during resolution by @jdx in [jdx#8050](jdx#8050) - **(release)** preserve aqua-registry sections in changelog across releases by @jdx in [jdx#8047](jdx#8047) - ls --all-sources shows duplicate entries by @roele in [jdx#8042](jdx#8042) ### 📚 Documentation - replace "inherit" terminology with config layering by @jdx in [jdx#8046](jdx#8046) ### 📦 Registry - switch oxlint to npm backend by default by @risu729 in [jdx#8038](jdx#8038) - add orval (npm:orval) by @zdunecki in [jdx#8051](jdx#8051) ### New Contributors - @zdunecki made their first contribution in [jdx#8051](jdx#8051)
Orval - Generate type-safe API clients from OpenAPI.