chore: use github backend instead of ubi in mise.lock#7922
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary of ChangesHello @jdx, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a minor configuration update within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the mise.lock file to use the github backend for the wait-for-gh-rate-limit tool, replacing the deprecated ubi backend. This is a good maintenance change that aligns with the project's direction. The change is correct and I see no issues.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ac3c1b5 to
43c82c0
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
| "platforms.linux-x64-musl" = { checksum = "sha256:a810b5083a830596cff3715402371917a200940efdeed6189bcde191e79d4633", url = "https://github.com/oven-sh/bun/releases/download/bun-v1.3.8/bun-linux-x64-musl.zip"} | ||
| "platforms.linux-x64-musl-baseline" = { checksum = "sha256:f05311fc12304ff8eaca136fc934eede6728055ba3d00cdb7e7dac394853f159", url = "https://github.com/oven-sh/bun/releases/download/bun-v1.3.8/bun-linux-x64-musl-baseline.zip"} | ||
| "platforms.macos-arm64" = { checksum = "sha256:672a0a9a7b744d085a1d2219ca907e3e26f5579fca9e783a9510a4f98a36212f", url = "https://github.com/oven-sh/bun/releases/download/bun-v1.3.8/bun-darwin-aarch64.zip"} | ||
| "platforms.macos-arm64" = { checksum = "blake3:167831b90e59f60eafdd5be230bd031885a0dcb7ce31fd9023a74634038b4900"} |
There was a problem hiding this comment.
Missing URL for bun on macOS arm64
High Severity
The platforms.macos-arm64 entry for bun had its download url removed, leaving only a checksum. All other platforms in the bun entry (and other core: backends like core:node) include both a checksum and URL. This inconsistency will likely cause bun installation to fail on macOS arm64 (Apple Silicon) systems since mise won't know where to download the binary from.
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.1.12 x -- echo |
16.4 ± 0.7 | 15.4 | 24.5 | 1.00 |
mise x -- echo |
17.4 ± 1.3 | 16.3 | 36.5 | 1.06 ± 0.09 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.1.12 env |
16.0 ± 0.5 | 15.2 | 19.9 | 1.00 |
mise env |
16.6 ± 0.3 | 15.8 | 17.8 | 1.04 ± 0.04 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.1.12 hook-env |
16.2 ± 0.3 | 15.4 | 17.2 | 1.00 |
mise hook-env |
17.0 ± 0.4 | 16.1 | 18.3 | 1.05 ± 0.03 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.1.12 ls |
15.4 ± 0.4 | 14.4 | 19.7 | 1.00 |
mise ls |
16.0 ± 0.3 | 15.0 | 17.1 | 1.04 ± 0.03 |
xtasks/test/perf
| Command | mise-2026.1.12 | mise | Variance |
|---|---|---|---|
| install (cached) | 85ms | 86ms | -1% |
| ls (cached) | 57ms | 58ms | -1% |
| bin-paths (cached) | 59ms | 60ms | -1% |
| task-ls (cached) | 2430ms | ✅ 467ms | +420% |
✅ Performance improvement: task-ls cached is 420%
### 🚀 Features - **(edit)** add interactive config editor (`mise edit`) by @jdx in [#7930](#7930) - **(lockfile)** graduate lockfiles from experimental by @jdx in [#7929](#7929) - **(task)** add support for usage values in task confirm dialog by @roele in [#7924](#7924) - **(task)** improve source freshness checking with edge case handling by @jdx in [#7932](#7932) ### 🐛 Bug Fixes - **(activate)** preserve ordering of paths appended after mise activate by @jdx in [#7919](#7919) - **(install)** sort failed installations for deterministic error output by @jdx in [#7936](#7936) - **(lockfile)** preserve URL and prefer sha256 when merging platform info by @jdx in [#7923](#7923) - **(lockfile)** add atomic writes and cache invalidation by @jdx in [#7927](#7927) - **(templates)** use sha256 for hash filter instead of blake3 by @jdx in [#7925](#7925) - **(upgrade)** respect tracked configs when pruning old versions by @jdx in [#7926](#7926) ### 🚜 Refactor - **(progress)** migrate from indicatif to clx by @jdx in [#7928](#7928) ### 📚 Documentation - improve clarity on uvx and pipx dependencies by @ygormutti in [#7878](#7878) ### ⚡ Performance - **(install)** use Kahn's algorithm for dependency scheduling by @jdx in [#7933](#7933) - use Aho-Corasick for efficient redaction by @jdx in [#7931](#7931) ### 🧪 Testing - remove flaky test_http_version_list test by @jdx in [#7934](#7934) ### Chore - use github backend instead of ubi in mise.lock by @jdx in [#7922](#7922) ### New Contributors - @ygormutti made their first contribution in [#7878](#7878)
## Summary - Replace `ubi:jdx/wait-for-gh-rate-limit` with `github:jdx/wait-for-gh-rate-limit` in mise.lock ## Test plan - [ ] Verify the tool installs correctly with the github backend 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Primarily lockfile churn, but it includes several dependency upgrades (notably `mlua-sys`/`lua-src`, `socket2`, and `windows-sys`) that could affect builds or runtime behavior, especially on Windows and where native Lua bindings are used. > > **Overview** > **Updates dependency/tool lockfiles.** `mise.lock` switches `wait-for-gh-rate-limit` from `ubi:` to `github:` and bumps a couple of pinned CLI tool versions (e.g., `cargo-insta`, `usage-cli`), plus adjusts the Bun macOS ARM checksum entry. > > **Refreshes Rust dependency pins.** `Cargo.lock` bumps several crates across the dependency graph (AWS Smithy crates, `clap`, `socket2`, `windows-sys`, `mlua`/`mlua-sys`/`lua-src`, and others), updating checksums and transitive requirements accordingly. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 43c82c0. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
### 🚀 Features - **(edit)** add interactive config editor (`mise edit`) by @jdx in [jdx#7930](jdx#7930) - **(lockfile)** graduate lockfiles from experimental by @jdx in [jdx#7929](jdx#7929) - **(task)** add support for usage values in task confirm dialog by @roele in [jdx#7924](jdx#7924) - **(task)** improve source freshness checking with edge case handling by @jdx in [jdx#7932](jdx#7932) ### 🐛 Bug Fixes - **(activate)** preserve ordering of paths appended after mise activate by @jdx in [jdx#7919](jdx#7919) - **(install)** sort failed installations for deterministic error output by @jdx in [jdx#7936](jdx#7936) - **(lockfile)** preserve URL and prefer sha256 when merging platform info by @jdx in [jdx#7923](jdx#7923) - **(lockfile)** add atomic writes and cache invalidation by @jdx in [jdx#7927](jdx#7927) - **(templates)** use sha256 for hash filter instead of blake3 by @jdx in [jdx#7925](jdx#7925) - **(upgrade)** respect tracked configs when pruning old versions by @jdx in [jdx#7926](jdx#7926) ### 🚜 Refactor - **(progress)** migrate from indicatif to clx by @jdx in [jdx#7928](jdx#7928) ### 📚 Documentation - improve clarity on uvx and pipx dependencies by @ygormutti in [jdx#7878](jdx#7878) ### ⚡ Performance - **(install)** use Kahn's algorithm for dependency scheduling by @jdx in [jdx#7933](jdx#7933) - use Aho-Corasick for efficient redaction by @jdx in [jdx#7931](jdx#7931) ### 🧪 Testing - remove flaky test_http_version_list test by @jdx in [jdx#7934](jdx#7934) ### Chore - use github backend instead of ubi in mise.lock by @jdx in [jdx#7922](jdx#7922) ### New Contributors - @ygormutti made their first contribution in [jdx#7878](jdx#7878)


Summary
ubi:jdx/wait-for-gh-rate-limitwithgithub:jdx/wait-for-gh-rate-limitin mise.lockTest plan
🤖 Generated with Claude Code
Note
Medium Risk
Primarily lockfile churn, but it includes several dependency upgrades (notably
mlua-sys/lua-src,socket2, andwindows-sys) that could affect builds or runtime behavior, especially on Windows and where native Lua bindings are used.Overview
Updates dependency/tool lockfiles.
mise.lockswitcheswait-for-gh-rate-limitfromubi:togithub:and bumps a couple of pinned CLI tool versions (e.g.,cargo-insta,usage-cli), plus adjusts the Bun macOS ARM checksum entry.Refreshes Rust dependency pins.
Cargo.lockbumps several crates across the dependency graph (AWS Smithy crates,clap,socket2,windows-sys,mlua/mlua-sys/lua-src, and others), updating checksums and transitive requirements accordingly.Written by Cursor Bugbot for commit 43c82c0. This will update automatically on new commits. Configure here.