fix(env): resolve sourced env for tool templates by corymhall · Pull Request #7895 · jdx/mise

corymhall · 2026-01-29T17:07:48Z

Tool versions that template env vars are rendered while reading mise.toml, so only literal [env] values were available in the context. This meant values from _.source / vfox env modules were missing, causing "Variable env.* not found" errors when tools referenced those vars.

This change resolves non-tool env results during config load and merges them into the per-file Tera context used for tool version rendering. The merge preserves local [env] values defined in the file, then overlays resolved env results (including removals) so sourced values are visible without changing explicit per-file overrides.

Examples:

[env]
_.source = "./set-go-version.sh"
[tools]
go = "{{env.MY_GO_VERSION}}"

[env]
_.vfox-myplugin = {}
[tools]
go = "{{env.MY_GO_VERSION}}"

Rationale:

Aligns tool templating with the documented "tools = true" / lazy env behavior by ensuring env directives are resolved before tool version templating.
Avoids changing tool resolution order beyond existing non-tools env pass.

Discussions:

Tool versions that template env vars are rendered while reading mise.toml, so only literal [env] values were available in the context. This meant values from _.source / vfox env modules were missing, causing "Variable env.* not found" errors when tools referenced those vars. This change resolves non-tool env results during config load and merges them into the per-file Tera context used for tool version rendering. The merge preserves local [env] values defined in the file, then overlays resolved env results (including removals) so sourced values are visible without changing explicit per-file overrides. Examples: ```toml [env] _.source = "./set-go-version.sh" [tools] go = "{{env.MY_GO_VERSION}}" ``` ```toml [env] _.vfox-myplugin = {} [tools] go = "{{env.MY_GO_VERSION}}" ``` Rationale: - Aligns tool templating with the documented "tools = true" / lazy env behavior by ensuring env directives are resolved before tool version templating. - Avoids changing tool resolution order beyond existing non-tools env pass. Discussions: - jdx#5733 - jdx#3782

Copilot

Pull request overview

This PR fixes an issue where tool versions using env var templates could only access literal [env] values, not those from _.source directives or vfox env modules. The fix resolves non-tool env results during config load and merges them into the Tera context used for tool version rendering.

Changes:

Pre-resolves env results during config load to ensure sourced env vars are available
Merges resolved env results into per-file Tera context for tool version templating
Updates method signatures to use Arc<Config> where needed for async operations

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File	Description
src/toolset/tool_request_set.rs	Changed `build` and `load_config_files` to accept `&Arc<Config>` instead of `&Config` to support async env_results calls
src/config/mod.rs	Added `env_results_cached()` method and pre-resolves env results during config load; updated `get_tool_request_set()` to require `Arc<Self>`
src/config/config_file/mise_toml.rs	Modified `to_tool_request_set()` to merge cached env results into the Tera context before rendering tool versions; added test for env source vars in tools
mise.lock	Added macOS ARM64 checksum for wait-for-gh-rate-limit tool

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

jdx · 2026-01-30T03:26:35Z

/gemini review

gemini-code-assist

Code Review

This pull request correctly resolves an issue where sourced environment variables were not available for tool version templating. The approach of resolving non-tool environment variables during config load and merging them into the Tera context is sound. The changes are well-contained and include a new test case that validates the fix. I have one minor suggestion to improve performance.

src/config/config_file/mise_toml.rs

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

corymhall · 2026-02-03T17:35:58Z

The original fix makes env directives (e.g., _.source, _.file, vfox env modules) available to tool version templates by resolving non‑tool env during config load. This is the desired behavior, but it moved module execution before the existing toolset env cache, which reintroduced the “plugins run every time”
regression (e2e/env/test_env_cache_plugin).

This change keeps the new behavior and restores the cache invariants by introducing a dedicated cache for non‑tool env results (i.e., ToolsFilter::NonToolsOnly) used during config load.

Key Changes

Non‑tool env cache
- Added CachedNonToolEnv in src/toolset/env_cache.rs.
- Reuses the same encryption/TTL + watch file validation as the existing env cache.
- Cache key uses config file mtimes, settings hash, base PATH (and a "non-tool-env" salt) — no tool versions.
- Stores the parts of EnvResults needed for templating: env, env_remove, env_paths, env_files, env_scripts, redactions, watch_files, etc.
Cache-aware config‑time env resolution
- Config::load_env now:
  - Loads from CachedNonToolEnv if enabled and valid.
  - On cache miss, resolves directives and saves back to cache if !has_uncacheable.
- Maintains existing eager resolution for templating, but with a fast path.
Docs update
- docs/dev-tools/index.md now reflects the intended behavior: tool templates can use env values from the config hierarchy, including env directives/modules.

Why this fixes CI

e2e/env/test_env_cache_plugin validates that MISE_ENV_CACHE=1 prevents plugin re‑execution across runs.
Previously, modules were executed during config load, before the toolset cache check.
With this change, config‑time env resolution is cached separately and avoids re‑running plugins when the cache is valid.

Behavioral Implications

Tool templates now see env values resolved from env directives across the config hierarchy (parent + child configs).
Env cache behavior remains intact:
- Plugins can still mark results cacheable = true and supply watch_files.
- Cache invalidates on config mtime changes, watch file changes, settings changes, TTL, mise version, etc.
Toolset env cache remains unchanged (still keyed on tool versions).

@corymhall

### 🐛 Bug Fixes - **(env)** resolve sourced env for tool templates by @corymhall in [#7895](#7895) - **(npm)** only declare the configured package manager as a dependency by @jdx in [#7995](#7995) - **(upgrade)** respect use_locked_version when checking tracked configs by @jdx in [#7997](#7997) - ignore MISE_TOOL_VERSION in env var parsing by @jdx in [#8004](#8004) ### New Contributors - @corymhall made their first contribution in [#7895](#7895)

@corymhall

This is no longer required as jdx/mise#6339 has been resolved by jdx/mise#7895 (thanks again @corymhall). We can now consume `env` variables directly. Given the huge blast radius of this change, I am triggering a dry-run on all providers first: https://github.com/pulumi/ci-mgmt/actions/runs/21947234269 From that run the only workflows that failed were: * pulumi/pulumi-gcp#3583 * pulumi/pulumi-vault#954 * pulumi/pulumi-terraform-module#727 * pulumi/pulumi-kubernetes#4141 And I verified those errors are unrelated to the change itself.

Tool versions that template env vars are rendered while reading mise.toml, so only literal [env] values were available in the context. This meant values from _.source / vfox env modules were missing, causing "Variable env.* not found" errors when tools referenced those vars. This change resolves non-tool env results during config load and merges them into the per-file Tera context used for tool version rendering. The merge preserves local [env] values defined in the file, then overlays resolved env results (including removals) so sourced values are visible without changing explicit per-file overrides. Examples: ```toml [env] _.source = "./set-go-version.sh" [tools] go = "{{env.MY_GO_VERSION}}" ``` ```toml [env] _.vfox-myplugin = {} [tools] go = "{{env.MY_GO_VERSION}}" ``` Rationale: - Aligns tool templating with the documented "tools = true" / lazy env behavior by ensuring env directives are resolved before tool version templating. - Avoids changing tool resolution order beyond existing non-tools env pass. Discussions: - jdx#5733 - jdx#3782 --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

@corymhall

### 🐛 Bug Fixes - **(env)** resolve sourced env for tool templates by @corymhall in [jdx#7895](jdx#7895) - **(npm)** only declare the configured package manager as a dependency by @jdx in [jdx#7995](jdx#7995) - **(upgrade)** respect use_locked_version when checking tracked configs by @jdx in [jdx#7997](jdx#7997) - ignore MISE_TOOL_VERSION in env var parsing by @jdx in [jdx#8004](jdx#8004) ### New Contributors - @corymhall made their first contribution in [jdx#7895](jdx#7895)

@corymhall

Previously: * #2040 * #2055 This is no longer required as jdx/mise#6339 has been resolved by jdx/mise#7895 (thanks again @corymhall). We can now consume `env` variables directly. Verified this change locally with `pulumi-eks`, `pulumi-gcp` and `pulumi-aws`.

Copilot AI review requested due to automatic review settings January 29, 2026 17:07

Copilot started reviewing on behalf of corymhall January 29, 2026 17:08 View session

Copilot AI reviewed Jan 29, 2026

View reviewed changes

autofix-ci bot and others added 2 commits January 29, 2026 17:16

[autofix.ci] apply automated fixes

91d94a9

Merge branch 'main' into fix-env-resolution

0911831

gemini-code-assist bot reviewed Jan 30, 2026

View reviewed changes

src/config/config_file/mise_toml.rs Outdated Show resolved Hide resolved

Update src/config/config_file/mise_toml.rs

3f15f4f

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

jdx marked this pull request as draft January 30, 2026 11:16

corymhall and others added 4 commits January 30, 2026 09:22

Merge branch 'main' into fix-env-resolution

3752878

Merge branch 'main' into fix-env-resolution

b5d594f

fix(env): cache non-tool env results for templating

5771724

[autofix.ci] apply automated fixes

d46bafc

corymhall added 3 commits February 3, 2026 12:54

Merge branch 'main' into fix-env-resolution

c0fbc9f

Merge branch 'main' into fix-env-resolution

9d123bf

Merge branch 'main' into fix-env-resolution

3c1f59a

corymhall marked this pull request as ready for review February 4, 2026 10:33

jdx merged commit 63ab65f into jdx:main Feb 4, 2026
34 checks passed

mise-en-dev mentioned this pull request Feb 4, 2026

chore: release 2026.2.4 #7999

Merged

BrewTestBot mentioned this pull request Feb 5, 2026

mise 2026.2.4 Homebrew/homebrew-core#265982

Merged

This was referenced Feb 5, 2026

Update mise to 2026.2.4 pulumi/ci-mgmt#2038

Closed

Remove get_env from Pulumi and Go version setting pulumi/ci-mgmt#2040

Merged

pose mentioned this pull request Feb 17, 2026

Remove get_env from Pulumi and Go version setting pulumi/ci-mgmt#2061

Merged

ringods mentioned this pull request Mar 4, 2026

Update mise action & version pulumi-labs/ci-mgmt#6

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(env): resolve sourced env for tool templates#7895

fix(env): resolve sourced env for tool templates#7895
jdx merged 11 commits intojdx:mainfrom
corymhall:fix-env-resolution

corymhall commented Jan 29, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

jdx commented Jan 30, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

corymhall commented Feb 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

corymhall commented Jan 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

jdx commented Jan 30, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

corymhall commented Feb 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants