Skip to content

fix(vfox-dotnet): use os.execute() to fix Windows installation#7843

Merged
jdx merged 1 commit intojdx:mainfrom
prodrigues1912:main
Jan 27, 2026
Merged

fix(vfox-dotnet): use os.execute() to fix Windows installation#7843
jdx merged 1 commit intojdx:mainfrom
prodrigues1912:main

Conversation

@prodrigues1912
Copy link
Copy Markdown
Contributor

@prodrigues1912 prodrigues1912 commented Jan 27, 2026

Summary

  • Fix .NET SDK installation failing on Windows
  • Replace cmd.exec() with os.execute() following the vfox-aapt2 pattern

Problem

On Windows, the cmd.exec() module captures stdout/stderr using Rust's Command::output(), which interferes with the dotnet-install.ps1 script execution. The script runs but fails silently, resulting in:

Installation failed: dotnet binary not found at C:\Users\...\dotnet.exe

Solution

Use os.execute() (Lua native function) instead of cmd.exec(). This allows stdout/stderr to go directly to the console, matching the pattern used in vfox-aapt2 which works correctly.

Test plan

  • Manual test on Windows with mise install dotnet@10.0.102
  • Verified dotnet --version works after installation

Fixes discussion #4738

@prodrigues1912 prodrigues1912 force-pushed the main branch 2 times, most recently from 741e366 to 6d17939 Compare January 27, 2026 03:50
@prodrigues1912 prodrigues1912 marked this pull request as draft January 27, 2026 03:50
Replace cmd.exec() with os.execute() following the vfox-aapt2 pattern.
The cmd.exec() module captures stdout/stderr which interferes with
the dotnet-install.ps1 script execution on Windows.
@prodrigues1912 prodrigues1912 changed the title fix(vfox-dotnet): use double quotes for Windows PowerShell paths fix(vfox-dotnet): use os.execute() to fix Windows installation Jan 27, 2026
@prodrigues1912 prodrigues1912 marked this pull request as ready for review January 27, 2026 05:07
@jdx jdx merged commit ca57ecf into jdx:main Jan 27, 2026
35 checks passed
mise-en-dev added a commit that referenced this pull request Jan 28, 2026
### 🚀 Features

- **(doctor)** add backend mismatch warnings by @jdx in
[#7847](#7847)
- **(http)** add rename_exe support for archive extraction by @jdx in
[#7874](#7874)
- **(http)** send x-mise-ci header for CI environment tracking by @jdx
in [#7875](#7875)
- **(install)** auto-install plugins from [plugins] config section by
@jdx in [#7856](#7856)
- **(registry)** add vercel by @mikecurtis in
[#7844](#7844)
- **(task)** support glob patterns in task_config.includes by @jdx in
[#7870](#7870)
- **(task)** add task templates for reusable task definitions by @jdx in
[#7873](#7873)

### 🐛 Bug Fixes

- **(backend)** change registry mismatch log from info to debug by @jdx
in [#7858](#7858)
- **(ci)** use squash merge for auto-merge-release workflow by @jdx in
[7e5e71e](7e5e71e)
- **(ci)** remove --auto flag to merge immediately when CI passes by
@jdx in
[23ed2ed](23ed2ed)
- **(github)** select platform-matching provenance file for SLSA
verification by @jdx in [#7853](#7853)
- **(go)** filter out version "1" from available versions by @jdx in
[#7871](#7871)
- **(install)** skip CurDir components when detecting archive structure
by @jdx in [#7868](#7868)
- **(pipx)** ensure Python minor version symlink exists for postinstall
hooks by @jdx in [#7869](#7869)
- **(registry)** prevent duplicate -stable suffix in Flutter download
URLs by @jdx in [#7872](#7872)
- **(task)** pass env to usage parser for env-backed arguments by @jdx
in [#7848](#7848)
- **(task)** propagate MISE_ENV to child tasks when using -E flag by
@jdx in
[06ee776](06ee776)
- **(vfox-dotnet)** use os.execute() to fix Windows installation by
@prodrigues1912 in [#7843](#7843)

### 📚 Documentation

- update cache-behavior with env_cache information by @jdx in
[#7849](#7849)

### ◀️ Revert

- remove task inheritance from parent configs in monorepos by @jdx in
[#7851](#7851)
- Revert "fix(ci): remove --auto flag to merge immediately when CI
passes" by @jdx in
[0606187](0606187)

### 📦 Registry

- add mago
([aqua:carthage-software/mago](https://github.com/carthage-software/mago))
by @scop in [#7845](#7845)

### Chore

- **(ci)** auto-merge release branch into main daily at 4am CST by @jdx
in [#7852](#7852)

### New Contributors

- @mikecurtis made their first contribution in
[#7844](#7844)
- @prodrigues1912 made their first contribution in
[#7843](#7843)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants