Skip to content

refactor: improve filetask field parsing tests and parser#7751

Merged
jdx merged 4 commits intojdx:mainfrom
makp0:feature/better-filetask-parsing-tests
Jan 20, 2026
Merged

refactor: improve filetask field parsing tests and parser#7751
jdx merged 4 commits intojdx:mainfrom
makp0:feature/better-filetask-parsing-tests

Conversation

@makp0
Copy link
Copy Markdown
Contributor

@makp0 makp0 commented Jan 19, 2026

Note

Strengthens task header parsing and tests.

  • Replace known_keys with tracking of parsed_keys; add unparsed_keys() to flag unknown fields and use it for error reporting
  • Validate alias vs aliases (mutually exclusive) and support parsing either; add confirm parsing
  • Expose parsed_keys() under tests and capture them via thread-local to verify every header line is parsed
  • Update integration tests to use aliases=[...], include confirm, and assert parsed vs script field count

Written by Cursor Bugbot for commit 210016e. This will update automatically on new commits. Configure here.

…` and improve unparsed key handling

- Added methods to retrieve parsed and unparsed keys for improved field tracking.
- Updated tests to validate proper parsing and field capture logic.
@makp0
Copy link
Copy Markdown
Contributor Author

makp0 commented Jan 19, 2026

bugbot run

@cursor
Copy link
Copy Markdown

cursor Bot commented Jan 19, 2026

Skipping Bugbot: Bugbot is disabled for this repository

@jdx jdx marked this pull request as draft January 19, 2026 15:10
@makp0 makp0 marked this pull request as ready for review January 20, 2026 00:52
@jdx
Copy link
Copy Markdown
Owner

jdx commented Jan 20, 2026

bugbot run

@jdx jdx merged commit 3637ffe into jdx:main Jan 20, 2026
35 checks passed
jdx pushed a commit that referenced this pull request Jan 20, 2026
### 🚀 Features

- **(config)** add miette diagnostics for TOML parsing errors by @jdx in
[#7764](#7764)
- **(env)** add environment caching with module cacheability support by
@jdx in [#7761](#7761)

### 🐛 Bug Fixes

- **(prepare)** handle freshness check for auto-created venvs by @jdx in
[#7770](#7770)
- **(release)** use colon separator in release titles by @jdx in
[#7765](#7765)
- **(release)** drop Fedora 41 from COPR build (EOL) by @TobiX in
[#7771](#7771)

### 🚜 Refactor

- improve filetask field parsing tests and parser by @makp0 in
[#7751](#7751)

### 📚 Documentation

- improve CLAUDE.md with additional development guidance by @jdx in
[#7763](#7763)
- drop architecture from Debian sources.list by @TobiX in
[#7772](#7772)

### 📦 Registry

- use aqua for zprint by @scop in
[#7767](#7767)

### Security

- remove insecure registry-comment workflow by @jdx in
[#7769](#7769)

## 📦 Aqua Registry Updates

#### New Packages (2)

-
[`cameron-martin/bazel-lsp`](https://github.com/cameron-martin/bazel-lsp)
- [`micro-editor/micro`](https://github.com/micro-editor/micro)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants