chore(registry): fix registry comment workflow#7554
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors duplicate registry tool detection logic by extracting it into a reusable composite GitHub Action. The refactoring improves maintainability by consolidating the logic for detecting modified and new tools in registry.toml into a single, shared action.
- Creates a new composite action
.github/actions/registry-diffthat detects modified and new tools in the registry - Updates two workflows (
registry_comment.ymlandregistry.yml) to use the new shared action - Standardizes output naming from kebab-case to snake_case for job outputs
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/actions/registry-diff/action.yml |
New composite action that uses yj to parse registry.toml and compare tool changes between commits, outputting both modified and new tools |
.github/workflows/registry_comment.yml |
Replaced inline bash script for detecting new tools with the new registry-diff action; updated output naming convention to snake_case |
.github/workflows/registry.yml |
Replaced inline tool diff logic with the new registry-diff action; extracted workflow file change check into a separate step for clarity |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b1153cb to
011d7a1
Compare
Owner
|
bugbot run |
Contributor
Author
|
@jdx can you try manually syncing sonar-scanner-cli to D1? |
Contributor
Author
|
Thank you! It's fixed now. |
Owner
|
bugbot run |
jdx
pushed a commit
that referenced
this pull request
Jan 13, 2026
### 🐛 Bug Fixes - **(backend)** filter pre-release versions with latest + install_before by @koh-sh in [#7631](#7631) - **(docs)** formatting in configuration hierarchy section by @jonathanagustin in [#7638](#7638) - **(npm)** migrate npm publish to OIDC trusted publishing by @jdx in [#7607](#7607) - **(registry)** correct checkmake version test pattern by @jdx in [#7632](#7632) - **(release)** handle empty grep result in aqua-registry changelog by @jdx in [f45b4c6](f45b4c6) - **(self-update)** self-update fails across year boundary due to semver mismatch by @jdx in [#7611](#7611) - **(tasks)** fix tool inheritance from intermediate parents by @chadxz in [#7637](#7637) - add `-test` to VERSION_REGEX prerelease filter by @belgio99 in [#7647](#7647) ### 📚 Documentation - **(tasks)** remove documentation for unimplemented features by @turbocrime in [#7599](#7599) - update `mise aliases` references to `mise tool-alias` by @muzimuzhi in [#7615](#7615) - use call operator in PowerShell profile example by @shina1024 in [#7639](#7639) - replace ASCII .pub key with binary .gpg for signed-by on Ubuntu/Debian by @gmalinowski in [#7649](#7649) ### 🛡️ Security - **(security)** prevent code execution from untrusted fork in registry-comment workflow by @jdx in [4a2441e](4a2441e) ###◀️ Revert - Revert "fix(release): handle empty grep result in aqua-registry changelog" by @jdx in [522ffdc](522ffdc) - Revert "chore(release): include manually updated aqua-registry entries in the changelog " by @jdx in [1ebb943](1ebb943) ### 📦️ Dependency Updates - update ghcr.io/jdx/mise:alpine docker digest to fbfffcf by @renovate[bot] in [#7619](#7619) - lock file maintenance by @renovate[bot] in [#7646](#7646) ### 📦 Registry - add hatoo/oha tool by @jylenhof in [#7633](#7633) ### Chore - **(registry)** fix registry comment workflow by @risu729 in [#7554](#7554) - **(release)** include manually updated aqua-registry entries in the changelog by @risu729 in [#7603](#7603) ### New Contributors - @belgio99 made their first contribution in [#7647](#7647) - @gmalinowski made their first contribution in [#7649](#7649) - @chadxz made their first contribution in [#7637](#7637) - @shina1024 made their first contribution in [#7639](#7639) - @jonathanagustin made their first contribution in [#7638](#7638) - @turbocrime made their first contribution in [#7599](#7599) ## 📦 Aqua Registry Updates #### New Packages (3) - [`ampcode/zvelte-check`](https://github.com/ampcode/zvelte-check) - [`nickel-lang/nickel`](https://github.com/nickel-lang/nickel) - [`openshift/rosa`](https://github.com/openshift/rosa)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow stopped working after the registry format change.
Note
Modernizes registry CI by centralizing tool-diff logic and refining conditions.
./.github/actions/registry-diffto computemodified_toolsandnew_toolsfromregistry.tomlregistry-comment.yml: rename workflow, replace ad-hoc grep logic with the new action, switch to snake_case outputs, and adjust title-validation conditions and PR comment gatingregistry.ymlto use the new action for listing changed tools, add a workflow-self-change check, and fall back to testing all tools when count > 30registry.toml, updatestools.firebasebackends to includenpm:firebase-toolsand disables its version test with a note about 15.2.0Written by Cursor Bugbot for commit 97f3ffb. This will update automatically on new commits. Configure here.