fix(ci): use !cancelled() instead of always() for registry-ci#7435
Merged
Conversation
The always() condition can cause registry-ci to report completion before all test-tool matrix jobs finish. Using !cancelled() ensures the job waits for all matrix tranches to complete.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a timing issue in the GitHub Actions workflow where the registry-ci status check job could start evaluating before all matrix jobs in the test-tool job complete. The change replaces always() with !cancelled() to ensure the job waits for all dependencies to finish while still skipping execution if the workflow is cancelled.
Key Changes:
- Modified the conditional expression for the
registry-cijob fromalways()to!cancelled()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.12.12 x -- echo |
19.5 ± 0.5 | 18.7 | 23.2 | 1.00 |
mise x -- echo |
20.0 ± 0.8 | 19.0 | 22.5 | 1.03 ± 0.05 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.12.12 env |
19.2 ± 0.6 | 18.4 | 24.0 | 1.00 |
mise env |
19.2 ± 0.4 | 18.5 | 21.1 | 1.00 ± 0.04 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.12.12 hook-env |
19.1 ± 0.3 | 18.4 | 20.7 | 1.00 |
mise hook-env |
19.3 ± 0.8 | 18.6 | 30.2 | 1.01 ± 0.05 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.12.12 ls |
16.6 ± 0.3 | 16.1 | 18.5 | 1.00 |
mise ls |
16.8 ± 0.3 | 16.3 | 17.8 | 1.01 ± 0.02 |
xtasks/test/perf
| Command | mise-2025.12.12 | mise | Variance |
|---|---|---|---|
| install (cached) | 107ms | 108ms | +0% |
| ls (cached) | 65ms | 65ms | +0% |
| bin-paths (cached) | 71ms | 71ms | +0% |
| task-ls (cached) | 4237ms | ✅ 280ms | +1413% |
✅ Performance improvement: task-ls cached is 1413%
jdx
pushed a commit
that referenced
this pull request
Dec 19, 2025
### 🚀 Features - **(tera)** add haiku() function for random name generation by @jdx in [#7399](#7399) - implement independent versioning for subcrates by @jdx in [#7402](#7402) ### 🐛 Bug Fixes - **(ci)** improve GHA cache efficiency and fix registry-ci bug by @jdx in [#7404](#7404) - **(ci)** use !cancelled() instead of always() for registry-ci by @jdx in [#7435](#7435) - **(test)** update backend_arg test to use clojure instead of poetry by @jdx in [#7436](#7436) ### 📚 Documentation - add link to COPR package page for Fedora/RHEL by @jdx in [bc8ac73](bc8ac73) - improve installation documentation by @jdx in [#7403](#7403) - add comprehensive glossary by @jdx in [#7401](#7401) ### 🧪 Testing - rename duplicate 'ci' job names for clarity by @jdx in [#7398](#7398) - add token pool integration for rate limit distribution by @jdx in [#7397](#7397) ### 📦 Registry - add github backend for swiftformat by @jdx in [#7396](#7396) - use pipx backend for azure-cli by @jdx in [#7406](#7406) - use pipx backend for dvc by @jdx in [#7413](#7413) - add github backend for zprint by @jdx in [#7410](#7410) - use gem backend for cocoapods by @jdx in [#7411](#7411) - use pipx backend for gallery-dl by @jdx in [#7409](#7409) - add aqua backends for HashiCorp tools by @jdx in [#7408](#7408) - use npm backend for danger-js by @jdx in [#7407](#7407) - use pipx backend for pipenv by @jdx in [#7415](#7415) - use pipx backend for poetry by @jdx in [#7416](#7416) - add github backend for xcodegen ([github:yonaskolb/XcodeGen](https://github.com/yonaskolb/XcodeGen)) by @jdx in [#7417](#7417) - use npm backend for heroku by @jdx in [#7418](#7418) - add aqua backend for setup-envtest by @jdx in [#7421](#7421) - add github backend for xcresultparser ([github:a7ex/xcresultparser](https://github.com/a7ex/xcresultparser)) by @jdx in [#7422](#7422) - add aqua backend for tomcat by @jdx in [#7423](#7423) - use npm backend for serverless by @jdx in [#7424](#7424) - add github backend for daytona ([github:daytonaio/daytona](https://github.com/daytonaio/daytona)) by @jdx in [#7412](#7412) - add github backend for flyway ([github:flyway/flyway](https://github.com/flyway/flyway)) by @jdx in [#7414](#7414) - add github backend for schemacrawler ([github:schemacrawler/SchemaCrawler](https://github.com/schemacrawler/SchemaCrawler)) by @jdx in [#7419](#7419) - add github backend for codeql by @jdx in [#7420](#7420) - use pipx backend for mitmproxy by @jdx in [#7425](#7425) - use pipx backend for sshuttle by @jdx in [#7426](#7426) - add github backend for quarkus by @jdx in [#7428](#7428) - add github backend for smithy by @jdx in [#7430](#7430) - add github backend for xchtmlreport ([github:XCTestHTMLReport/XCTestHTMLReport](https://github.com/XCTestHTMLReport/XCTestHTMLReport)) by @jdx in [#7431](#7431) - add github backend for grails by @jdx in [#7429](#7429) - use npm backend for esy by @jdx in [#7434](#7434) - add github backend for micronaut by @jdx in [#7433](#7433) - add github backend for dome by @jdx in [#7432](#7432) - use vfox backend for poetry by @jdx in [#7438](#7438) ### Chore - **(docker)** add Node LTS to mise Docker image by @jdx in [#7405](#7405) - rename mise-tools to mise-versions by @jdx in [ab3e1b8](ab3e1b8) - s/mise task/mise tasks/g in docs and tests by @muzimuzhi in [#7400](#7400) ### New Contributors - @muzimuzhi made their first contribution in [#7400](#7400)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if: always()toif: ${{ !cancelled() }}The
always()condition can cause timing issues with matrix jobs where the status check job starts evaluating before all tranches complete. Using!cancelled()ensures the job properly waits for all matrix jobs to finish (success or failure) while still not running if the workflow is cancelled.Note
Switches the
registry-cijob condition fromalways()to${{ !cancelled() }}in.github/workflows/registry.yml.Written by Cursor Bugbot for commit f93fdfd. This will update automatically on new commits. Configure here.